Fix issue where ListPrompt throws or hangs on null key input (empty text / blank read) 2168 - #2174
Open
HillkirkLautaro wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2168
Changes
ListPrompt.Showwhere anullvalue returned from_console.Input.ReadKeyAsync(such as during empty text/key reads) could cause a malformed loop structure or unhandled flow issues.try-finallyblocks andwhileloop handling for input reading, cursor visibility toggling (_console.Cursor.Hide()/Show()), and render hook refreshes.MultiSelectionPromptTestsandThrowingCursor) to ensure proper cursor management and behavior when hiding the cursor throws or when input is handled under edge conditions.