Automatic load balancing with dynamic thread pool - #187
Draft
colbynyce-mips wants to merge 4 commits into
Draft
Conversation
Collaborator
|
Marking this as a draft until Argos collector app is in place first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature will be needed for scalability down the road when we have multiple apps running at the same time. Without these changes, every app's non-database pipeline stage is currently given its own thread, regardless of sleeping/working ratios. Right now, we typically see single-app usage resulting in non-DB threads sleeping most of the time. The waste is minimal but SimDB won't scale without a thread pool.
Please review the Argos PR first. Later, we will do before/after perf comparisons when running Sparta reports (csv) + Argos + Profiler all together to see the difference the pool makes.