[cleaner] Skip Size for directory output - #4459
Open
mahimabhosale wants to merge 1 commit into
Open
Conversation
sos clean always printed Size from os.stat() of the output path. For a directory that is inode metadata (commonly 4KiB), not the obfuscated data size. Report Size only for packed archives, matching the archive-vs-directory split in Policy.display_results. Closes: sosreport#4396 Signed-off-by: Mahima Bhosale <mabhosal@redhat.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
TurboTurtle
reviewed
Aug 27, 2026
TurboTurtle
left a comment
Member
There was a problem hiding this comment.
As a suggestion, we could still report the cumulative directory size instead of not printing anything.
def get_directory_size(path):
total_size = 0
try:
with os.scandir(path) as flist:
for _f in flist:
if _f.is_file(follow_symlinks=False):
total_size += _f.stat(follow_symlinks=False).st_size
elif _f.is_dir(follow_symlinks=False):
total_size += get_directory_size(_f.path)
except PermissionError:
# ignore these instead of bailing out on size calculation
pass
return total_size
get_human_readable(get_directory_size(final_path))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sos clean always printed Size from os.stat() of the output path.
For a directory that is inode metadata (commonly 4KiB), not the
obfuscated data size.
Report Size only for packed archives, matching the
archive-vs-directory split in Policy.display_results.
Closes: #4396
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines