[docker] Declare docker in the services tuple - #4444
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
setup() calls add_journal() for the docker unit but the plugin declares no services tuple and never collects the service status. An sosreport from a host where dockerd has failed to start therefore contains the journal but nothing showing whether the unit is loaded, enabled or running. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the unit adds the missing status and replaces the explicit call. It also gives the plugin an enablement trigger beyond the package name. The base class declares no packages and the two distribution subclasses list ten names between them, while the unit is docker in every case. The SoSPredicate on the following line is unaffected: it gates whether the docker subcommands run, which is separate from the plugin's services attribute. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup()callsadd_journal()for the docker unit but the plugin declares noservicestuple and never collects the service status. An sosreport from ahost where dockerd has failed to start therefore contains the journal but
nothing showing whether the unit is loaded, enabled or running.
Plugin._collect_services()runs each entry of the tuple throughis_service()and calls bothadd_service_status()andadd_journal(), sodeclaring the unit adds the missing status and replaces the explicit call.
It also gives the plugin an enablement trigger beyond the package name. The
base class declares no
packagesand the two distribution subclasses list tennames between them, while the unit is
dockerin every case.The
SoSPredicateon the following line is unaffected — it gates whether thedocker subcommands run, which is separate from the plugin's
servicesattribute.
Follow-up to #4443, as offered there.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines