[openvswitch] Declare the OVS units in the services tuple - #4439
Open
suraj-cmd wants to merge 1 commit into
Open
[openvswitch] Declare the OVS units in the services tuple#4439suraj-cmd wants to merge 1 commit into
suraj-cmd wants to merge 1 commit into
Conversation
setup() calls add_journal() for six units - openvswitch, openvswitch-nonetwork, ovs-vswitchd, ovsdb-server, ovs-configuration and openvswitch-ipsec - but the plugin declares no services tuple and collects no service status for any of them. An sosreport from a host where ovs-vswitchd or ovsdb-server has failed to start therefore has the journal but nothing showing the unit state, which is usually the first thing checked when OVS is down. Plugin._collect_services() runs each entry of the tuple through is_service() and calls both add_service_status() and add_journal(), so declaring the units adds the six missing statuses and replaces the explicit calls. The tuple is declared on the shared base class so it applies to both distribution subclasses. The virtual-accelerator journal in collect_ovs_info() is left as an explicit call: it is guarded by an is_installed() check for 6windgate-fp and so is conditional rather than a property of the plugin. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup()callsadd_journal()for six units —openvswitch,openvswitch-nonetwork,ovs-vswitchd,ovsdb-server,ovs-configurationand
openvswitch-ipsec— but the plugin declares noservicestuple andcollects no service status for any of them.
An sosreport from a host where
ovs-vswitchdorovsdb-serverhas failed tostart therefore has the journal but nothing showing the unit state, which is
usually the first thing checked when OVS is down.
Plugin._collect_services()runs each entry of the tuple throughis_service()and calls bothadd_service_status()andadd_journal(), sodeclaring the units adds the six missing statuses and replaces the explicit
calls.
The tuple is declared on the shared base class so it applies to both
distribution subclasses.
The
virtual-acceleratorjournal incollect_ovs_info()is deliberately leftas an explicit call: it is guarded by an
is_installed()check for6windgate-fpand so is conditional rather than a property of the plugin.Follows @TurboTurtle's review comment on #4429, and the same change made in
#4436, #4437 and #4438. The before/after behaviour is demonstrated on #4437,
where
systemctl_status_chronydappears only with the change applied.Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines