[atd] Add plugin for the at job scheduler - #4421
Open
suraj-cmd wants to merge 1 commit into
Open
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Member
|
If you can, please test the function of the plugin, just to ensure that it collects the right things please |
cron.py covers cron, but nothing in the tree references atd, /etc/at.allow, /etc/at.deny, /var/spool/at or atq. An sosreport from a host using at contains no record of the daemon, its access control files or its pending queue. The plugin collects the allow and deny lists, the distribution defaults files, atq output, and the service status and journal for atd. Queued jobs under /var/spool/at are not copied. Each is a complete shell script that embeds the submitting user's environment, which frequently includes exported credentials. A recursive directory listing is taken instead, which still shows the pending jobs, their queue, ownership and submission time. The units are declared in the services tuple rather than explicit add_service_status() and add_journal() calls, per review on sosreport#4429. Signed-off-by: Suraj Patil <surajpatil522@gmail.com>
suraj-cmd
force-pushed
the
add-atd-plugin
branch
from
August 13, 2026 19:26
6380fb0 to
5a9548f
Compare
Contributor
Author
|
@arif-ali Tested on my RHEL-10 VM What changed since he looked. The units now come from services = ('atd',) rather than explicit add_service_status()/add_journal() calls, per the review on #4429 — and systemctl_status_atd and the journal are still collected, so the tuple does the work. |
pmoravec
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cron.pycovers cron, but nothing in the tree referencesatd,/etc/at.allow,/etc/at.deny,/var/spool/atoratq. An sosreport from ahost using
atcontains no record of the daemon, its access control files orits pending queue.
The plugin collects the allow and deny lists, the distribution defaults files,
atqoutput, and the service status and journal foratd.Queued jobs under
/var/spool/atare not copied. Each is a complete shellscript that embeds the submitting user's environment, which frequently includes
exported credentials. A recursive directory listing is taken instead, which
still shows the pending jobs, their queue, ownership and submission time.
I do not have a system with pending at jobs to test the spool listing against.
The decision not to copy job bodies is the part I would most like a second
opinion on —
cron.pydoes collect/var/spool/cron, so there is an argumentfor consistency, but at job files embed the submitter's environment in a way
crontabs do not.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines