[collect/RHCOS] Fix sos collect on RHCOS nodes with SSH transport

[dwolstroRH]

            nodes, two issues occurred:

1. sos was not detected because RHELPolicy matched RHCOS nodes before RedHatCoreOSPolicy could be checked (both have ID=rhel in os-release)

2. Spurious namespace deletion error occurred with SSH transport because cleanup() tried to delete a namespace that was never created (namespaces are only created for 'oc' transport)

Fixes:

• Add check() override to RHELPolicy to explicitly reject RHCOS nodes
• Add RHEL version detection (8/9/10) from os-release for dynamic support-tools image selection
• Update create_sos_container() to use support-tools image with proper mount points and 'sleep infinity' to keep container running
• Fix ocp cluster cleanup() to only delete namespace when using 'oc' transport, not SSH transport

Related: SUPDEV-226

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
• Are all passwords or private data gathered by this PR obfuscated?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo dnf install -y 'dnf*-command(copr)'
• dnf copr enable packit/sosreport-sos-4393
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[pmoravec]

What is the typical /etc/os-release content on CoreOS, please? I would prefer some other method to distinguish among the classes, other than chaning the parent class check method.

Also, I feel the one commit aims to beat multiple flies, it is worth splitting it into more, for the sake of clarity (this makes sense to do once we agree on the first point).

[pmoravec]

sos was not detected because RHELPolicy matched RHCOS nodes before RedHatCoreOSPolicy could be checked (both have ID=rhel in os-release)

This should be fixed by #4397 so no need to extract RedHatCoreOSPolicy to a new file.

[pmoravec]

Tentatively approving it - I would like to see the self.project = None "merged" from both if-then-else branches, and got confirmation on the "sleep forever" understanding. Plus the DCO is still wrong. Otherwise LGTM.

[dwolstroRH]

Tentatively approving it - I would like to see the self.project = None "merged" from both if-then-else branches, and got confirmation on the "sleep forever" understanding. Plus the DCO is still wrong. Otherwise LGTM.

Sleep infinity keeps the container process alive so we can exec into it for sos report collection. This makes the -i
(interactive) flag unnecessary since the container no longer needs an interactive shell to stay running. The force_pull option is now honored as well.

The DCO should hopefully be fixed as well

[TurboTurtle]

Absolutely not, no embedded bash scripting in sos.