Master Key Encryption HLD - #2493
Draft
fredxia-nexthop wants to merge 2 commits into
Draft
Conversation
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Fix issues based on review comments: - Remove the design of allowing multiple master encryption keys - Remove storing of historical keys. Replace with activate_key/candidate_key to store active and staging keys - Remove invocation of openssl. Replace with built-in random key generation in master-key-manager - Remove some implementation details - Add ZTP and gNMI integration in Future Work - Add explanation on why decryption is application-specific and at place of use, while encryption is automatic and transparent Signed-off-by: Fred Xia <fredxia@nexthop.ai>
fredxia-nexthop
force-pushed
the
fredxia-master-key-encryption
branch
from
August 11, 2026 18:47
3e31816 to
8b7bdc6
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues based on review comments: