Repository navigation
refactor: 소식지 단일 좋아요 여부 확인 API 제거 #455
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,23 @@ | ||
| package com.example.solidconnection.news.repository; | ||
|
|
||
| import com.example.solidconnection.news.domain.LikedNews; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| public interface LikedNewsRepository extends JpaRepository<LikedNews, Long> { | ||
|
|
||
| boolean existsByNewsIdAndSiteUserId(long newsId, long siteUserId); | ||
|
|
||
| Optional<LikedNews> findByNewsIdAndSiteUserId(long newsId, long siteUserId); | ||
|
|
||
| @Query(""" | ||
| SELECT l.newsId | ||
| FROM LikedNews l | ||
| WHERE l.newsId IN :newsIds AND l.siteUserId = :siteUserId | ||
| """) | ||
| Set<Long> findLikedNewsIdsByNewsIdsAndSiteUserId(@Param("newsIds") List<Long> newsIds, @Param("siteUserId") Long siteUserId); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.example.solidconnection.news.fixture; | ||
|
|
||
| import com.example.solidconnection.news.domain.LikedNews; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.boot.test.context.TestComponent; | ||
|
|
||
| @TestComponent | ||
| @RequiredArgsConstructor | ||
| public class LikedNewsFixture { | ||
|
|
||
| private final LikedNewsFixtureBuilder likedNewsFixtureBuilder; | ||
|
|
||
| public LikedNews 소식지_좋아요(long newsId, long siteUserId) { | ||
| return likedNewsFixtureBuilder.likedNews() | ||
| .newsId(newsId) | ||
| .siteUserId(siteUserId) | ||
| .create(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.example.solidconnection.news.fixture; | ||
|
|
||
| import com.example.solidconnection.news.domain.LikedNews; | ||
| import com.example.solidconnection.news.repository.LikedNewsRepository; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.springframework.boot.test.context.TestComponent; | ||
|
|
||
| @TestComponent | ||
| @RequiredArgsConstructor | ||
| public class LikedNewsFixtureBuilder { | ||
|
|
||
| private final LikedNewsRepository likedNewsRepository; | ||
|
|
||
| private long newsId; | ||
|
|
||
| private long siteUserId; | ||
|
|
||
| public LikedNewsFixtureBuilder likedNews() { | ||
| return new LikedNewsFixtureBuilder(likedNewsRepository); | ||
| } | ||
|
|
||
| public LikedNewsFixtureBuilder newsId(long newsId) { | ||
| this.newsId = newsId; | ||
| return this; | ||
| } | ||
|
|
||
| public LikedNewsFixtureBuilder siteUserId(long siteUserId) { | ||
| this.siteUserId = siteUserId; | ||
| return this; | ||
| } | ||
|
|
||
| public LikedNews create() { | ||
| LikedNews likedNews = new LikedNews(newsId, siteUserId); | ||
| return likedNewsRepository.save(likedNews); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠.. 지금 전체적인 코드에 '좋아요 했음'이
isLiked와isLike가 혼용되고 있네요🤔통일하는게 좋아보이는데, 둘 중 뭐가 더 좋다 생각하시나요?
(디스코드에도 질문 올려두겠습니다.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isLiked로 결정된 거 같아서 반영하였습니다~ 452b4c7