Binary eio v3 + Engine IO v3, v4 Interop JS integration tests

.gitattributes

@@ -0,0 +1,9 @@
+# Auto-detect text files and normalize line endings
+* text=auto
+
+# Declare explicit line endings for java files
+*.java text eol=lf
+*.xml text eol=lf
+*.yml text eol=lf
+*.yaml text eol=lf
+*.md text eol=lf

.github/workflows/build-pr.yml

@@ -18,14 +18,10 @@ jobs:
   build:
     strategy:
       matrix:
-        include:
-          - java-version: 17
-            delay: 0
-          - java-version: 21
-            delay: 0
-          - java-version: 25
-            delay: 0
+        os: [ubuntu-latest]
+        java-version: [17, 21, 25]
     uses: ./.github/workflows/build.yml
     with:
+      os: "${{ matrix.os }}"
       javaVersion: "${{ matrix.java-version }}"
-      delay: "${{ matrix.delay }}"
+      interopVersions: "smoke"

.github/workflows/build.yml

@@ -9,14 +9,22 @@ on:
       javaVersion:
         required: true
         type: string
+      os:
+        required: false
+        type: string
+        default: "ubuntu-latest"
       delay:
         required: false
         type: string
         default: "0"
+      interopVersions:
+        required: false
+        type: string
+        default: "smoke"
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ inputs.os }}
 
     env:
       # Allow Testcontainers to control Docker
@@ -26,39 +34,69 @@ jobs:
     steps:
       # --- Staggered delay ---
       - name: Stagger job start
-        run: sleep ${{ inputs.delay }}
+        env:
+          DELAY: ${{ inputs.delay }}
+        run: sleep "$DELAY"
 
       # --- Checkout ---
       - name: Checkout
-        uses: actions/checkout@v4
-
-      # --- Enable Docker (already preinstalled on runners) ---
-      - name: Start Docker daemon
-        run: |
-          sudo systemctl start docker
-          sudo systemctl status docker --no-pager
-
-      # --- Validate Docker works ---
-      - name: Docker Info
-        run: docker info
+        uses: actions/checkout@v7
 
       # --- Java / Maven Setup ---
       - name: Set up Java
-        uses: actions/setup-java@v3
+        uses: actions/setup-java@v5
         with:
           java-version: ${{ inputs.javaVersion }}
           distribution: temurin
           cache: maven
 
+      # --- Node.js 22 Setup with Package Caching ---
+      - name: Set up Node.js
+        uses: actions/setup-node@v7
+        with:
+          node-version: 22
+          cache: 'npm'
+          cache-dependency-path: 'netty-socketio-core/src/test/resources/js-interop/package-lock.json'
+
+      # --- Install JS Client Interop Dependencies ---
+      - name: Install JS Interop Dependencies
+        working-directory: netty-socketio-core/src/test/resources/js-interop
+        run: npm ci
+
+      # --- Cache Playwright Browsers ---
+      - name: Cache Playwright Browsers
+        id: playwright-cache
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/ms-playwright
+          key: ${{ runner.os }}-playwright-${{ hashFiles('netty-socketio-core/src/test/resources/js-interop/package-lock.json', 'netty-socketio-core/src/test/resources/js-interop/package.json') }}
+          restore-keys: |
+            ${{ runner.os }}-playwright-
+
+      # --- Install Playwright Browsers & OS Deps (On Cache Miss) ---
+      - name: Install Playwright Browsers & OS Deps
+        if: steps.playwright-cache.outputs.cache-hit != 'true'
+        working-directory: netty-socketio-core/src/test/resources/js-interop
+        run: npx playwright install --with-deps chromium firefox webkit
+
+      # --- Install OS Deps Only (On Cache Hit) ---
+      - name: Install Playwright OS Dependencies
+        if: steps.playwright-cache.outputs.cache-hit == 'true'
+        working-directory: netty-socketio-core/src/test/resources/js-interop
+        run: npx playwright install-deps chromium firefox webkit
+
       # --- Testcontainers configuration for CI ---
       - name: Disable Testcontainers reuse
         run: |
           echo "testcontainers.reuse.enable=false" > ~/.testcontainers.properties
-          cat ~/.testcontainers.properties
 
       # --- Build + Tests ---
       - name: Build Project
-        timeout-minutes: 90
+        timeout-minutes: 120
         run: |
-          export MAVEN_OPTS="-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=WARN"
-          mvn --batch-mode --errors --fail-at-end -DforkCount=1 verify
+          export MAVEN_OPTS="-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=WARN \
+                             -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN \
+                             -Dcom.socketio4j.socketio.level=WARN \
+                             -Dio.netty.leakDetection.level=PARANOID"
+          mvn --batch-mode --errors --fail-at-end -Dsocketio.test.forkCount=1C \
+            -Dsocketio.interop.versions=${{ inputs.interopVersions }} verify

.github/workflows/maven-publish.yml

@@ -4,15 +4,22 @@
     types: [created]
   workflow_dispatch:
 jobs:
-  build:
+  verify-release:
+    uses: ./.github/workflows/build.yml
+    with:
+      javaVersion: "21"
+      interopVersions: "full"
+
+  publish:
+    needs: verify-release
     runs-on: ubuntu-latest
     permissions:
       contents: read
       packages: write
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v7
     - name: Set up JDK 21
-      uses: actions/setup-java@v4
+      uses: actions/setup-java@v5
       with:
           java-version: '21'
           distribution: 'temurin'
@@ -27,5 +34,5 @@
       env:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
-      # for publish, skip test, because test is in CI
+      # Interop and project verification run in verify-release above.
       run: mvn --batch-mode -DskipTests -Dgpg.passphrase=${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }} clean deploy -P release

.gitignore

@@ -10,4 +10,5 @@
 **/.vscode
 **/.idea
 **/*.iml
-**/dependency-reduced-pom.xml
+**/dependency-reduced-pom.xml
+**/node_modules/

checkstyle.xml

@@ -191,7 +191,9 @@
         <module name="NestedIfDepth">
            <property name="max" value="3"/>
         </module>
-        <module name="NestedTryDepth"/>
+        <module name="NestedTryDepth">
+              <property name="max" value="2"/>
+        </module>
         <module name="NoClone"/>
         <module name="NoFinalizer"/>
         <module name="OneStatementPerLine"/>

netty-socketio-core/pom.xml

@@ -152,11 +152,6 @@
       <artifactId>testcontainers-kafka</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.jmockit</groupId>
-      <artifactId>jmockit</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>net.bytebuddy</groupId>
       <artifactId>byte-buddy-agent</artifactId>
@@ -177,6 +172,16 @@
       <artifactId>junit-platform-launcher</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.junit.platform</groupId>
+      <artifactId>junit-platform-suite-api</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.platform</groupId>
+      <artifactId>junit-platform-suite-engine</artifactId>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.testcontainers</groupId>
       <artifactId>testcontainers</artifactId>
@@ -207,6 +212,12 @@
       <artifactId>socket.io-client</artifactId>
       <scope>test</scope>
     </dependency>
+    <!-- OkHttp for raw HTTP/WS integration tests (EIOv3, SSL, etc.) -->
+    <dependency>
+      <groupId>com.squareup.okhttp3</groupId>
+      <artifactId>okhttp</artifactId>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>com.github.javafaker</groupId>
       <artifactId>javafaker</artifactId>
@@ -242,4 +253,94 @@
       </dependency>
   </dependencies>
 
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <configuration>
+          <!-- Suites are manual aggregation entry points. Running them during
+               normal discovery duplicates the classes they select. -->
+          <excludes>
+            <exclude>**/*Suite.java</exclude>
+            <!-- These four classes run together in the execution below so
+                 they can share one rigorously-reset single-node fixture. -->
+            <exclude>**/JsClientInteropTest.java</exclude>
+            <exclude>**/JsMultiClientInteropTest.java</exclude>
+            <exclude>**/JsNamespaceInteropTest.java</exclude>
+            <exclude>**/JsTransportInteropTest.java</exclude>
+            <!-- The common single-node protocol profile runs in the same
+                 isolated fixture execution as the compatible JS clients. -->
+            <exclude>**/integration/protocol/*Test.java</exclude>
+            <exclude>**/AbruptDisconnectBinaryUploadIntegrationTest.java</exclude>
+            <!-- Container-backed and distributed tests consume Docker and
+                 shared local compute resources. JUnit resource locks do not
+                 cross Surefire JVMs, so run these through the isolated
+                 execution below rather than the 1C worker pool. -->
+            <exclude>**/integration/cluster/**/*Test.java</exclude>
+            <exclude>**/integration/interop/Distributed*InteropTest.java</exclude>
+            <exclude>**/store/HazelcastStoreFactoryTest.java</exclude>
+            <exclude>**/store/HazelcastStoreTest.java</exclude>
+            <exclude>**/store/RedissonReliableStoreFactoryTest.java</exclude>
+            <exclude>**/store/RedissonStoreTest.java</exclude>
+            <exclude>**/store/event/HazelcastRingBufferEventStoreTest.java</exclude>
+            <exclude>**/store/event/RedisPubSubEventStoreTest.java</exclude>
+          </excludes>
+        </configuration>
+        <executions>
+          <execution>
+            <id>external-service-integration</id>
+            <phase>test</phase>
+            <goals>
+              <goal>test</goal>
+            </goals>
+            <configuration>
+              <!-- A dedicated serial worker prevents Docker resource
+                   contention while retaining a complete Surefire report for
+                   nested test classes. Each top-level test class owns and
+                   stops its container in its class lifecycle; its backend
+                   state therefore cannot flow into the next class. -->
+              <forkCount>1</forkCount>
+              <reuseForks>true</reuseForks>
+              <includes combine.self="override">
+                <include>**/integration/cluster/**/*Test.java</include>
+                <include>**/integration/interop/Distributed*InteropTest.java</include>
+                <include>**/store/HazelcastStoreFactoryTest.java</include>
+                <include>**/store/HazelcastStoreTest.java</include>
+                <include>**/store/RedissonReliableStoreFactoryTest.java</include>
+                <include>**/store/RedissonStoreTest.java</include>
+                <include>**/store/event/HazelcastRingBufferEventStoreTest.java</include>
+                <include>**/store/event/RedisPubSubEventStoreTest.java</include>
+              </includes>
+              <excludes combine.self="override" />
+            </configuration>
+          </execution>
+          <execution>
+            <id>shared-single-node-js-interop</id>
+            <phase>test</phase>
+            <goals>
+              <goal>test</goal>
+            </goals>
+            <configuration>
+              <!-- This worker deliberately remains single-process. The
+                   ordinary execution stays parallel through
+                   socketio.test.forkCount. -->
+              <forkCount>1</forkCount>
+              <reuseForks>true</reuseForks>
+              <includes combine.self="override">
+                <include>**/JsClientInteropTest.java</include>
+                <include>**/JsMultiClientInteropTest.java</include>
+                <include>**/JsNamespaceInteropTest.java</include>
+                <include>**/JsTransportInteropTest.java</include>
+                <include>**/integration/protocol/*Test.java</include>
+                <include>**/AbruptDisconnectBinaryUploadIntegrationTest.java</include>
+              </includes>
+              <excludes combine.self="override" />
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+
 </project>

netty-socketio-core/src/main/java/com/socketio4j/socketio/AckRequest.java

@@ -85,7 +85,7 @@ public void sendAckData(List<Object> objs) {
         if (!isAckRequested() || !sent.compareAndSet(false, true)) {
             return;
         }
-        Packet ackPacket = new Packet(PacketType.MESSAGE, client.getEngineIOVersion());
+        Packet ackPacket = new Packet(PacketType.MESSAGE);
         ackPacket.setSubType(PacketType.ACK);
         ackPacket.setAckId(originalPacket.getAckId());
         ackPacket.setData(objs);

netty-socketio-core/src/main/java/com/socketio4j/socketio/SingleRoomBroadcastOperations.java

@@ -21,8 +21,10 @@
 import java.util.Objects;
 import java.util.function.Predicate;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.socketio4j.socketio.misc.IterableCollection;
-import com.socketio4j.socketio.protocol.EngineIOVersion;
 import com.socketio4j.socketio.protocol.Packet;
 import com.socketio4j.socketio.protocol.PacketType;
 import com.socketio4j.socketio.store.StoreFactory;
@@ -34,6 +36,7 @@
  * Date: 2020/8/8 6:08 PM
  */
 public class SingleRoomBroadcastOperations implements BroadcastOperations {
+    private static final Logger log = LoggerFactory.getLogger(SingleRoomBroadcastOperations.class);
     private final String namespace;
     private final String room;
     private final Iterable<SocketIOClient> clients;
@@ -61,7 +64,6 @@ public Collection<SocketIOClient> getClients() {
     @Override
     public void send(Packet packet) {
         for (SocketIOClient client : clients) {
-            packet.setEngineIOVersion(client.getEngineIOVersion());
             client.send(packet);
         }
         dispatch(packet);
@@ -92,13 +94,12 @@ public void sendEvent(String name, SocketIOClient excludedClient, Object... data
 
     @Override
     public void sendEvent(String name, Predicate<SocketIOClient> excludePredicate, Object... data) {
-        Packet packet = new Packet(PacketType.MESSAGE, EngineIOVersion.UNKNOWN);
+        Packet packet = new Packet(PacketType.MESSAGE);
         packet.setSubType(PacketType.EVENT);
         packet.setName(name);
         packet.setData(Arrays.asList(data));
 
         for (SocketIOClient client : clients) {
-            packet.setEngineIOVersion(client.getEngineIOVersion());
             if (excludePredicate.test(client)) {
                 continue;
             }
@@ -109,7 +110,7 @@ public void sendEvent(String name, Predicate<SocketIOClient> excludePredicate, O
 
     @Override
     public void sendEvent(String name, Object... data) {
-        Packet packet = new Packet(PacketType.MESSAGE, EngineIOVersion.UNKNOWN);
+        Packet packet = new Packet(PacketType.MESSAGE);
         packet.setSubType(PacketType.EVENT);
         packet.setName(name);
         packet.setData(Arrays.asList(data));