fix(deps): remediate 21 dependency vulnerabilities (bun audit) - #61
Open
doanhv wants to merge 1 commit into
Open
fix(deps): remediate 21 dependency vulnerabilities (bun audit)#61doanhv wants to merge 1 commit into
doanhv wants to merge 1 commit into
Conversation
bun audit found 21 vulnerabilities (1 critical, 12 high, 7 moderate, 1 low) in transitive dependencies. Assessed real reachability per package before acting, rather than bulk-bumping blindly: - react-router-dom ^7.8.1 -> ^7.18.1 (apps/web): fixes all 9 react-router advisories (open redirects, SSR/RSC XSS, vendored turbo-stream arbitrary constructor invocation, CSRF, DoS). apps/web is a client-only BrowserRouter SPA (no SSR/RSC entrypoint), so the worst advisories were not reachable here, but the in-range patch bump is free and safe -- still major version 7, no breaking changes in this apps usage (BrowserRouter/Routes/Route/Navigate/Link/ useLocation only). - Added diff (>=8.0.3) and file-type (>=21.3.1) to the existing root overrides block: both are transitive deps of @opentui/core (used for TUI image rendering via jimp), pinned/ranged to old vulnerable versions upstream. Verified via a direct dynamic-import smoke test that @opentui/core and its image-rendering submodule still load correctly with the overridden versions. Remaining 8 vulnerabilities (shell-quote, ws, ip-address, basic-ftp) are deliberately deferred, not silently ignored: - shell-quote (critical) + ws: only reachable via react-devtools-core, a peerDependency of @opentui/react gated behind a DEV=true-only code branch (not the default runtime path); no upstream patch exists yet for shell-quote regardless. - ip-address + basic-ftp: transitive to electrobuns PAC/SOCKS-proxy resolution chain (desktop app packaging), not a directly-used FTP feature. Verified: full-workspace bun run typecheck (16/16 clean), bun run test (all workspaces green except 2 pre-existing, unrelated failures on a sibling branch), bun run lint:check (only the 1 known pre-existing unrelated nit), bun run build:dashboard (apps/web builds cleanly). Independently reviewed by a fresh code-reviewer (APPROVE), including a follow-up on a flagged residual risk (jimp/image-rendering path untested by any existing test -- confirmed unreachable from ccflares own TUI code and runtime-smoke-tested regardless).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for full details: react-router-dom bumped to 7.18.1 (fixes 9 advisories), diff/file-type pinned via overrides (fixes 2 more), 8 remaining vulnerabilities deliberately deferred with documented reachability reasoning (no upstream patch / gated behind DEV-only code path / not a used feature).