Skip to content

Fix Python 3 compatibility : replace iteritems() with items() and fix IndexError on empty parameters #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alegio98 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Python 3 compatibility : replace iteritems() with items() and fix IndexError on empty parameters #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/snapista/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def add_node(self, operator, node_id, source=None):

elif isinstance(source, dict):

for key, value in source.iteritems():
for key, value in source.items():

source_product_elem = etree.SubElement(sources_elem, key)
source_product_elem.text = value
Expand Down Expand Up @@ -346,14 +346,12 @@ def add_node(self, operator, node_id, source=None):

parameter_elem = etree.SubElement(parameters_elem, param)

if getattr(operator, param) is not None:
if getattr(operator, param)[0] != "<":
parameter_elem.text = getattr(operator, param)
val = getattr(operator, param)
if val is not None:
if len(str(val)) > 0 and str(val)[0] == "<":
p_elem.text.append(etree.fromstring(val))
else:
parameter_elem.append(
etree.fromstring(getattr(operator, param))
)

p_elem.text = str(val)
node_elem.attrib["id"] = node_id

operator_elem.text = operator.operator
Expand Down