feat: Add lane off-chain readiness preflight - #1432
Open
athegaul wants to merge 2 commits into
Open
Conversation
New preflight package checks that the verifier and executor jobs serving a lane chain exist, are approved, and that their deployed spec covers that chain. The lane changesets in chainlink-ccip cannot read this job state, so this closes the gap before a lane is wired up.
|
👋 athegaul, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
athegaul
changed the title
athegaul
changed the title
…ead of string concatenation
|
Code coverage report:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Job selection and deployed-spec validation can produce incorrect or nondeterministic readiness results.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds preflight validation for off-chain lane readiness.
Changes:
- Checks verifier and executor jobs for existence, approval, and chain coverage.
- Adds tests for missing, unapproved, and incomplete jobs.
File summaries
| File | Description |
|---|---|
deployment/preflight/lane_prereqs.go |
Implements lane readiness checks. |
deployment/preflight/lane_prereqs_test.go |
Tests readiness outcomes. |
Review details
Suppressed comments (2)
deployment/preflight/lane_prereqs.go:129
- Qualifier matching is not position-aware. For example, qualifier
defaultalso matchesnop-default-other-verifierbecausedefaultappears in the alias/aggregator portion, even though that job belongs to committeeother. This can select a job from the wrong scope; the existing scope implementations indeployment/shared/types.go:127-129and:193-195match the complete trailing scope instead.
return strings.HasSuffix(jobID, "-"+kind) && strings.Contains(jobID, "-"+qualifier+"-")
deployment/preflight/lane_prereqs.go:123
JobInfo.Specis the locally desired spec, not necessarily the deployed one: JD's proposal specs are stored inProposals, and sync explicitly permits/report spec drift without replacing this field. Consequently, an approved job whose deployed spec omits this chain can pass if the local desired spec contains it. Also, a raw substring can match the selector in unrelated values or as part of another selector. Read the active proposal's spec and parse the relevant verifier/executor chain-config map to test an exact key.
if !strings.Contains(found.Spec, chainKey) {
return fmt.Errorf("NOP %q job %q: %w", alias, found.JobID, ErrJobMissingChain)
}
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+108
to
+112
| for jobID, info := range jobs[alias] { | ||
| if jobMatches(string(jobID), kind, qualifier) { | ||
| found = &info | ||
| break | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New preflight package checks that the verifier and executor jobs serving a lane chain exist, are approved, and that their deployed spec covers that chain. The lane changesets in chainlink-ccip cannot read this job state, so this closes the gap before a lane is wired up.