fix: pass unbounded queries through without bisection - #1429
Merged
Conversation
nvsriram
marked this pull request as ready for review
September 8, 2026 14:27
makramkd
previously approved these changes
Sep 8, 2026
|
Code coverage report:
|
makramkd
approved these changes
Sep 9, 2026
flodesi
approved these changes
Sep 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes theLatestAndFinalizedBlockcall for unbounded queries and send them through without bisection. This is in order to avoid running into "block range extends beyond current head block" error when the node that returned the value ofLatestAndFinalizedBlockreturned a block that is ahead of the node that handled theFilterLogscallThis PR reverts the bisection logic and reduces the
DefaultMaxBlockRangeto 100 (from 1500)