refactor(indexer): rename the replay tool to backfill - #1421
Open
tt-cll wants to merge 1 commit into
Open
Conversation
tt-cll
force-pushed
the
tt/indexer-backfill-rename
branch
from
September 9, 2026 11:20
4168d17 to
138dfef
Compare
tt-cll
force-pushed
the
tt/indexer-backfill-rename
branch
from
September 9, 2026 12:38
138dfef to
1e20222
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The advisory-lock key prefix change can allow concurrent execution across old/new binaries during rollout, undermining the crash-recovery mutual exclusion guarantee.
Pull request overview
This PR renames the indexer “replay” tool/module to “backfill” to avoid terminology collisions, updating the Go package naming, CLI surface, documentation, and supporting build/test wiring.
Changes:
- Renamed the Go package (and public-facing CLI strings/logs/errors) from replay → backfill across the indexer backfill engine.
- Updated build artifacts and container images to produce
/bin/indexer-backfillinstead of/bin/indexer-replay. - Updated E2E smoke tests and CI workflow patterns to target the renamed backfill CLI/tests.
File summaries
| File | Description |
|---|---|
| indexer/pkg/storage/postgres.go | Updates storage comments to refer to “backfill” terminology. |
| indexer/pkg/backfill/types.go | Renames package and user-facing error strings/comments from replay → backfill. |
| indexer/pkg/backfill/types_test.go | Updates test package name to backfill. |
| indexer/pkg/backfill/store.go | Renames error strings and lock-key prefix to backfill; adds table-name compatibility note. |
| indexer/pkg/backfill/README.md | Renames module docs and CLI examples to indexer-backfill; documents rename rationale. |
| indexer/pkg/backfill/message.go | Renames message replay runner/function/log strings to backfill. |
| indexer/pkg/backfill/engine.go | Renames engine terminology, logger name, and error strings to backfill. |
| indexer/pkg/backfill/engine_test.go | Renames tests/helpers/types to backfill terminology. |
| indexer/pkg/backfill/discovery.go | Renames discovery replay runner/function/log strings to backfill. |
| indexer/Justfile | Renames build target to build-backfill and output binary name. |
| indexer/Dockerfile.dev | Builds /bin/indexer-backfill from cmd/backfill. |
| indexer/Dockerfile | Builds and copies /bin/indexer-backfill into the final image. |
| indexer/cmd/backfill/main.go | Renames CLI app name/usage/commands and switches imports to pkg/backfill. |
| build/devenv/tests/e2e/smoke_backfill_cli_test.go | Updates E2E smoke tests to execute indexer-backfill and renamed tests/messages. |
| .github/workflows/test-smoke.yaml | Updates smoke workflow entry to run TestE2ESmoke_Backfill*. |
Review details
Suppressed comments (1)
indexer/pkg/backfill/store.go:158
- Changing the advisory-lock key prefix from
replay:tobackfill:can break crash-recovery / mutual exclusion during rollout: an olderindexer-replayprocess and the newindexer-backfillprocess could acquire different locks for the same job ID and run concurrently. Since the table name remainsreplay_jobsfor migration compatibility, it’s safer to keep the lock key stable as well (or otherwise coordinate a one-time migration/compat layer).
- Files reviewed: 15/15 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tt-cll
force-pushed
the
tt/indexer-backfill-rename
branch
from
September 9, 2026 16:20
1e20222 to
e438089
Compare
tt-cll
force-pushed
the
tt/indexer-backfill-rename
branch
from
September 9, 2026 19:36
e438089 to
9a04fd0
Compare
tt-cll
force-pushed
the
tt/indexer-backfill-rename
branch
from
September 9, 2026 23:10
9a04fd0 to
2f34a98
Compare
|
Code coverage report:
Files removed (from
Files added (in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Checklist
changelogdirectory)Stack created with GitHub Stacks CLI • Give Feedback 💬