fix(indexer): unsigned selector and sequence number in client response models - #1419
Open
tt-cll wants to merge 2 commits into
Open
fix(indexer): unsigned selector and sequence number in client response models#1419tt-cll wants to merge 2 commits into
tt-cll wants to merge 2 commits into
Conversation
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 9, 2026 11:20
5b32559 to
8351a71
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes align generated client response models with the correct unsigned ranges, and remaining feedback is limited to minor consistency/documentation improvements.
Pull request overview
Updates the indexer’s generated OpenAPI Go client models so chain selectors and message sequence numbers use unsigned types that can represent the full value range produced by CCIP/protocol types.
Changes:
- Change
Message.{Source,Dest}ChainSelectorin the generated client model fromint64toprotocol.ChainSelector. - Change
Message.SequenceNumberin the generated client model fromint64to an unsigned integer type. - Extend the OpenAPI overlay to apply these type overrides to response schemas (not just query parameters).
File summaries
| File | Description |
|---|---|
| indexer/pkg/client/internal/client.go | Adjusts generated response model field types for chain selectors and sequence number. |
| indexer/overlay.yaml | Adds overlay rules to force correct Go types/imports for response schema properties. |
Review details
Files not reviewed (1)
- indexer/pkg/client/internal/client.go: Generated file
Suppressed comments (1)
indexer/overlay.yaml:66
- The overlay sets
sequence_numbertouint64, but the codebase already definesprotocol.SequenceNumber(auint64-based domain type). Using the domain type keeps generated response models consistent withprotocol.Messageand the selector overrides above.
- target: "$.components.schemas.Message.properties.sequence_number"
update:
x-go-type: uint64
- Files reviewed: 1/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+48
to
+51
| # Response models. Selectors are uint64 and a third of the values in chain-selectors exceed | ||
| # maxInt64, so the generated int64 cannot represent them at all; sequence numbers are | ||
| # non-negative (minimum: 0), which int64 does not carry. The parameter actions above only | ||
| # cover the query string; these cover the components.schemas the responses are built from. |
| ReceiverLength int32 `json:"receiver_length"` | ||
| Sender string `json:"sender"` | ||
| SenderLength int32 `json:"sender_length"` | ||
| SequenceNumber uint64 `json:"sequence_number"` |
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
2 times, most recently
from
September 9, 2026 16:20
208739d to
389f8cf
Compare
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 9, 2026 19:36
389f8cf to
ebed5c9
Compare
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 9, 2026 23:10
ebed5c9 to
54d9375
Compare
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 10, 2026 14:40
54d9375 to
45b6ffe
Compare
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 10, 2026 18:12
45b6ffe to
669b2ea
Compare
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 10, 2026 19:28
669b2ea to
ca32cea
Compare
Collaborator
|
Is this a breaking change? Any idea who is using this OpenAPI Go client? |
carte7000
previously approved these changes
Sep 11, 2026
tt-cll
force-pushed
the
tt/indexer-selector-types
branch
from
September 11, 2026 12:53
f0fb9fb to
6939112
Compare
|
Code coverage report:
|
carte7000
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Checklist
changelogdirectory)Stack created with GitHub Stacks CLI • Give Feedback 💬