fix(verifier): reject [policy_hook] in Chainlink-node mode at boot - #1414
Merged
Conversation
|
👋 tt-cll, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new contract conflicts with existing documentation/changelog and there are a couple of correctness/clarity issues in the updated constructor/docs that should be addressed first.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Chainlink-node (integration constructor) entry point to reject any [policy_hook] configuration at startup, reflecting that the policy hook is only supported in the standalone verifier deployment mode.
Changes:
- Update policy hook documentation to state that
[policy_hook]is not supported when running inside a Chainlink node. - Remove the functional option plumbing (
WithPolicyHookCredential, options resolver) previously used to support policy hook credentials in the Chainlink-node constructor. - Update the Chainlink-node constructor to hard-fail if
cfg.PolicyHookis set, and to wire the coordinator with the ungatedcommitVerifier.
File summaries
| File | Description |
|---|---|
| verifier/docs/policy_hook.md | Clarifies that [policy_hook] is unsupported in Chainlink-node mode and should fail at startup. |
| integration/pkg/constructors/options.go | Deleted: removes the now-obsolete functional option used to pass policy hook credentials. |
| integration/pkg/constructors/committee_verifier.go | Rejects [policy_hook] in Chainlink-node mode and removes policy hook gating/wrapping from this constructor. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+58
to
+62
| // The policy hook is not supported on a verifier running inside a Chainlink node: its HMAC | ||
| // credential is resolved from the standalone verifier's secrets file, which does not exist | ||
| // here. Configuring the section must fail loudly rather than screen traffic with an | ||
| // unauthenticated hook. | ||
| if cfg.PolicyHook != nil { |
makramkd
reviewed
Sep 9, 2026
tt-cll
force-pushed
the
tt/policy-hook-cl-mode-error
branch
from
September 9, 2026 11:20
935a12c to
1731ce6
Compare
|
Code coverage report:
Files removed (from
|
makramkd
approved these changes
Sep 9, 2026
carte7000
approved these changes
Sep 9, 2026
This was referenced Sep 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Checklist
changelogdirectory)Stack created with GitHub Stacks CLI • Give Feedback 💬