Skip to content

Fix macOS CI by building against openssl@3 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tedmalone wants to merge 2 commits into
base: surrogate
Choose a base branch
from
Open

Fix macOS CI by building against openssl@3 #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa8d426
ci: build macOS against openssl@3
tedmalone Aug 10, 2026
6e00673
ci(macos): drop the redundant openssl symlink step
tedmalone Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,13 @@ jobs:
uses: actions/checkout@v2
# See https://github.com/google/go-tpm-tools#macos-dev
- name: Install openssl
run: brew install openssl@1.1
run: brew install openssl@3
- name: Link openssl
run: sudo ln -s $(brew --prefix openssl@1.1)/include/openssl /usr/local/include
run: |
sudo mkdir -p /usr/local/include
sudo ln -sfn "$(brew --prefix openssl@3)/include/openssl" /usr/local/include/openssl

@maraino maraino Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary, you're already adding the C_INCLUDE_PATH bellow. Tested on a macOS with openssl in /opt/homebrew/...

$ brew --prefix openssl@3
/opt/homebrew/opt/openssl@3

@tedmalone tedmalone Aug 12, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — removed the Link openssl step (6e00673). The Test step already points cgo at the headers/libs via C_INCLUDE_PATH/LIBRARY_PATH using brew --prefix openssl@3, which resolves on both the Intel (/usr/local) and Apple Silicon (/opt/homebrew) layouts, so the /usr/local/include/openssl symlink was redundant. Thanks!

- name: Test
run: C_INCLUDE_PATH="$(brew --prefix openssl@1.1)/include" LIBRARY_PATH="$(brew --prefix openssl@1.1)/lib" go test ./...
run: C_INCLUDE_PATH="$(brew --prefix openssl@3)/include" LIBRARY_PATH="$(brew --prefix openssl@3)/lib" go test ./...
test-windows:
strategy:
matrix:
Expand Down
Loading