fix(submission): Auto-transform ProtectedDonor workbooks during validate/submit - #48
Open
aschroed wants to merge 10 commits into
Open
fix(submission): Auto-transform ProtectedDonor workbooks during validate/submit#48aschroed wants to merge 10 commits into
aschroed wants to merge 10 commits into
Conversation
|
New Issues (3)Checkmarx found the following issues in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
… fm/protected-donor-submitr # Conflicts: # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Intent
Add selective ProtectedDonor workbook analysis and transformation across dcicutils and submitr. Protected-item sheets are Demographic, DeathCircumstances, FamilyHistory, MedicalHistory, and TissueCollection. Mixed Donor and ProtectedDonor references are supported; missing workbook Donors fail clearly; existing ProtectedDonors may come from the workbook or portal; unreferenced Donors remain unchanged; and validate/submit perform the transformation without an interactive transform prompt.
What changed
Remediation updates
StructuredDataSet.dataserialized to temporary JSON as the canonical remote validation/submission payload, so CustomExcel mappings such asqc_values#...are preserved. The transformed.xlsxremains available as the user-visible artifact.Testing
Focused submitr tests cover the ProtectedDonor transform, mapped upload payload, cached formula behavior, output preservation/replacement, and malformed-workbook handling. The dcicutils changes and tests are in 4dn-dcic/utils#339.
This PR is intentionally not merged automatically; the dcicutils beta implementation/release must remain coordinated with this branch.