Skip to content

Update Browser title independent from rebuild. #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabianbrandscheid wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update Browser title independent from rebuild. #668

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4bfa7ec
Add files via upload
fabianbrandscheid Jul 16, 2024
c6d1823
Add files via upload
fabianbrandscheid Jul 16, 2024
f8f769d
Add files via upload
fabianbrandscheid Jul 16, 2024
34c6879
Add files via upload
fabianbrandscheid Jul 16, 2024
0941ad2
Add files via upload
fabianbrandscheid Jul 16, 2024
5725030
Delete package/lib/beamer_delegate.dart
fabianbrandscheid Jul 16, 2024
6394a92
Add files via upload
fabianbrandscheid Jul 16, 2024
7732113
Add files via upload
fabianbrandscheid Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions package/lib/src/beamer_delegate.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,10 @@ class BeamerDelegate extends RouterDelegate<RouteInformation>
// run guards on _beamStackCandidate
final context = _context;
if (context != null) {
if (configuration != null) {
_setBrowserTitle(context,
fixTitle: configuration.uri.pathSegments.last);
}
final didApply = _runGuards(context, _beamStackCandidate);
_didRunGuards = true;
if (didApply) {
Expand Down Expand Up @@ -986,10 +990,12 @@ class BeamerDelegate extends RouterDelegate<RouteInformation>
}
}

void _setBrowserTitle(BuildContext context) {
void _setBrowserTitle(BuildContext context, {String? fixTitle}) {
if (active && setBrowserTabTitle) {
final String title = _currentPages.last.title ??
currentBeamStack.state.routeInformation.uri.path;
final String title = fixTitle ?? _currentPages.last.title ??
currentBeamLocation.state.routeInformation.uri.path;
browser_tab_title_util.setTabTitle(title);
}
}
Expand Down Expand Up @@ -1135,4 +1141,4 @@ class BeamerDelegate extends RouterDelegate<RouteInformation>
updateListenable?.removeListener(_update);
super.dispose();
}
}
}