Repository navigation
feat(checkbox): add indeterminate state - #188
Merged
Merged
Conversation
checked, value, and defaultChecked accept 'indeterminate', rendering a dash glyph (Minus icon for the surface kind) while onChange keeps emitting a boolean. Switches render indeterminate as unchecked.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f87b5fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ CI — All checks passed · 923 testsView workflow run · 923 passed
Unit test breakdown
Vitest · 68 test files · View full run |
Contributor
|
🤖 Docs audit — no documentation drift detected. No documentation updates needed — the Checkbox indeterminate change's in-scope doc impacts (AGENTS.md component inventory, public/llms.txt usage line) were already updated within the change itself, and no other in-scope doc states any fact the diff contradicts. Generated by docs-sentinel. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
checked,value, anddefaultCheckedacceptboolean | 'indeterminate';onChangekeeps emitting a boolean, so a{...field}spread still round-trips. Toggling from indeterminate emitstrue. Thedefault/panelkinds render a dash glyph,surfacerenders the newMinusicon, andkind="switch"renders indeterminate as unchecked. Includes a minor changeset.QA
Inputs/Checkbox › Indeterminatestory: "Select all" shows the dash with a partial selection and checks/unchecks every option on clickdefault,panel, andsurfacekinds in both light and dark themes, including disabledIcon › Minusstory rendersTesting
bun run typecheck— pass, by handbunx vitest run --project unit src/stories/checkbox src/stories/icon— 88 passed, by handbunx biome checkon changed files — pass, by hand (repo-widebun run lintfails on pre-existingCombobox.tsxandbiome.jsonschema issues onmain)indeterminatetests:aria-checked="mixed"for default/surface/panel kinds, click emitstrue,valuealias, uncontrolleddefaultChecked, nocheckedcontainer class, switch renders uncheckedRisk
Low — additive API on one component; existing boolean usage is unchanged.
Checkboxrendering andonChangefor all consumers