Skip to content

ci: show main branch link text in release PR description - #683

Merged
zimeg merged 2 commits into
mainfrom
mwbrooks-fix-release-pr-main-link
Oct 2, 2026
Merged

zimeg merged 2 commits into
mainfrom
mwbrooks-fix-release-pr-main-link

Conversation

@mwbrooks

@mwbrooks mwbrooks commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Changelog

N/A - CI only.

Summary

The release PR description renders the first Testing checkbox with an empty link where main should be (see #681). The body is built with an unquoted heredoc, so the backticks around main are treated as shell command substitution and replaced with empty output.

This removes the backticks so the link text renders as plain main.

Testing

  • Next run of the release workflow should render: Confirm unit tests and E2E tests are passing on the main branch.

Requirements

The release PR body is built with an unquoted heredoc, so backticks around
main were run as command substitution and the link text rendered empty.
@mwbrooks mwbrooks self-assigned this Oct 2, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented build M-T: Changes to compilation and CI processes semver:patch Use on pull requests to describe the release version increment labels Oct 2, 2026
@mwbrooks
mwbrooks marked this pull request as ready for review October 2, 2026 21:44
@mwbrooks
mwbrooks requested a review from a team as a code owner October 2, 2026 21:44
@mwbrooks mwbrooks added this to the Next Release milestone Oct 2, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks Amazing catch so let's merge this? Now!

@zimeg
zimeg merged commit f7e1cbb into main Oct 2, 2026
11 checks passed
@zimeg
zimeg deleted the mwbrooks-fix-release-pr-main-link branch October 2, 2026 21:45
@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.23%. Comparing base (e70c8bc) to head (cafe3fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   78.23%   78.23%           
=======================================
  Files         239      239           
  Lines       18149    18149           
=======================================
+ Hits        14198    14199    +1     
+ Misses       3951     3950    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented build M-T: Changes to compilation and CI processes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants