Skip to content

feat: support the code_channels manifest feature - #641

Merged
zimeg merged 3 commits into
mainfrom
clack/manifest-code-channels
Sep 11, 2026
Merged

feat: support the code_channels manifest feature#641
zimeg merged 3 commits into
mainfrom
clack/manifest-code-channels

Conversation

@zimeg

@zimeg zimeg commented Aug 17, 2026

Copy link
Copy Markdown
Member

Changelog

Add support for the code_channels app manifest feature.

Summary

Adds the code_channels feature block to the manifest types so the CLI can read, write, and round-trip it (enabled, optional slash_command_url). Follows the existing feature-block pattern; validation is handled by the manifest validation endpoint.

Requirements

Add the code_channels feature block to the manifest types so the CLI can
read, write, and round-trip it (enabled, optional slash_command_url).
Follows the existing feature-block pattern; validation is handled by the
manifest validation endpoint.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg added enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment changelog Use on updates to be included in the release notes labels Aug 17, 2026
@zimeg zimeg self-assigned this Aug 17, 2026
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.21%. Comparing base (de89617) to head (93e7393).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   78.22%   78.21%   -0.02%     
==========================================
  Files         239      239              
  Lines       18176    18176              
==========================================
- Hits        14219    14217       -2     
- Misses       3957     3959       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zimeg zimeg added this to the Next Release milestone Aug 19, 2026
@zimeg
zimeg marked this pull request as ready for review August 19, 2026 18:58
@zimeg
zimeg requested a review from a team as a code owner August 19, 2026 18:58
@zimeg
zimeg marked this pull request as draft August 19, 2026 22:06
@zimeg

zimeg commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

🧪 Testing and such ongoing so this keeps in draft!

@zimeg zimeg removed this from the v4.7.0 milestone Aug 28, 2026
@zimeg
zimeg marked this pull request as ready for review September 11, 2026 19:37
@zimeg zimeg added this to the Next Release milestone Sep 11, 2026

@zimeg zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌚 A note for the kind review! ✨

ManifestSlashCommandsItems []ManifestSlashCommandsItem `json:"slash_commands,omitempty" yaml:"slash_commands,flow,omitempty"`
Search *Search `json:"search,omitempty" yaml:"search,flow,omitempty"`
RichPreviews *RichPreviews `json:"rich_previews,omitempty" yaml:"rich_previews,flow,omitempty"`
CodeChannels *CodeChannels `json:"code_channels,omitempty" yaml:"code_channels,flow,omitempty"`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ note: This matches some of the implementation of #670!

@srtaalej srtaalej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zimeg

zimeg commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

@srtaalej Super appreciate checking this out for confidence! Let's merge this to precede #670.

@zimeg
zimeg enabled auto-merge (squash) September 11, 2026 19:51
@zimeg
zimeg merged commit 6614222 into main Sep 11, 2026
13 checks passed
@zimeg
zimeg deleted the clack/manifest-code-channels branch September 11, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants