Fix migration outage test - #1228
Draft
mxsrc wants to merge 1 commit into
Draft
Conversation
Depending on which path was taken the test would consistently fail. The scenarios (source, target, unrelated) are all relevant and need to be tested reliably. This PR adapts the tests s.t. one test case is dedicated to each of the different outage variants.
mxsrc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on which path was taken the test would consistently fail. The scenarios (source, target, unrelated) are all relevant and need to be tested reliably. This PR adapts the tests s.t. one test case is dedicated to each of the different outage variants.
The resulting test behavior exposes a broken handling of an outage in the source node, which is fixed by ...