Repository navigation
Row JSON now returns {"row": {...}} - #3071
Merged
Merged
Conversation
/database/table/pk.json previously returned the row as the only item in a "rows" list. It now returns it as an object in a "row" key. Two other keys change to match: "truncated" is no longer included, since a single row lookup cannot be truncated, and the render_cell extra is a single object keyed by column name instead of a list of one. Any ?_shape= option returns the same shapes as table JSON, so ?_shape=objects gives the previous format. Output renderer plugins are still passed a rows list containing the one row. The row edit dialog reads the new shape. Closes #2612, closes #2137 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 80 80
Lines 13999 14006 +7
=====================================
- Misses 13999 14006 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
# Conflicts: # docs/changelog.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/database/table/pk.jsonreturned the row as the only item in a"rows"list. It now returns it as an object in a"row"key:{ "ok": true, "database": "fixtures", "table": "simple_primary_key", "primary_keys": ["id"], "primary_key_values": ["1"], "query_ms": 1.2, "row": {"id": 1, "content": "hello"} }This is a breaking change to the JSON API.
Claude Fable 5.2 Medium
It replaces the row shape part of #2986, re-implemented against the new
json_renderer(). The infinity fix from that PR is not included here.What changes
"row"in place of"rows"."truncated"is no longer in that response. It was alwaysfalse.?_extra=render_cellreturns a single object keyed by column name, in place of a list containing one object.?_shape=option returns the same shapes as table JSON, so?_shape=objectsgives the previous format, including"truncated"andrender_cellas a list.rowslist containing the one row.edit-tools.jsreadsdata.row.Docs
docs/json_api.rst.render_cellextra example for row pages, regenerated with cog.Testing
Closes #2612, closes #2137
🤖 Generated with Claude Code