Repository navigation
Limit total facet suggestion time for a page, closes #862 - #3068
Merged
Merged
Conversation
Suggesting facets runs a query per column per facet type, each allowed facet_suggest_time_limit_ms, so a wide table could spend seconds on it. All facet instances for a page now share a deadline of ten times that setting. The built-in suggest() methods stop considering columns once it passes, and facet types that have not started are skipped. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016BvfqA1vxyJtmTEN1TTTgR
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3068 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 79 79
Lines 13930 13952 +22
=====================================
- Misses 13930 13952 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggesting facets runs a query per column per facet type, each allowed
facet_suggest_time_limit_ms, so a wide table could spend seconds on it.
All facet instances for a page now share a deadline of ten times that
setting. The built-in suggest() methods stop considering columns once
it passes, and facet types that have not started are skipped.
Co-Authored-By: Claude Fable 5.2 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_016BvfqA1vxyJtmTEN1TTTgR