Skip to content

Limit total facet suggestion time for a page, closes #862 - #3068

Merged
simonw merged 1 commit into
mainfrom
claude/intelligent-brahmagupta-3w188l
Nov 15, 2026
Merged

simonw merged 1 commit into
mainfrom
claude/intelligent-brahmagupta-3w188l

Conversation

@simonw

@simonw simonw commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Suggesting facets runs a query per column per facet type, each allowed
facet_suggest_time_limit_ms, so a wide table could spend seconds on it.

All facet instances for a page now share a deadline of ten times that
setting. The built-in suggest() methods stop considering columns once
it passes, and facet types that have not started are skipped.

Co-Authored-By: Claude Fable 5.2 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_016BvfqA1vxyJtmTEN1TTTgR

Suggesting facets runs a query per column per facet type, each allowed
facet_suggest_time_limit_ms, so a wide table could spend seconds on it.

All facet instances for a page now share a deadline of ten times that
setting. The built-in suggest() methods stop considering columns once
it passes, and facet types that have not started are skipped.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016BvfqA1vxyJtmTEN1TTTgR
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (abdcca9) to head (4b84497).

Files with missing lines Patch % Lines
datasette/facets.py 0.00% 18 Missing ⚠️
datasette/views/table_extras.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3068   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         79      79           
  Lines      13930   13952   +22     
=====================================
- Misses     13930   13952   +22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simonw
simonw merged commit 805efa4 into main Nov 15, 2026
15 checks passed
@simonw
simonw deleted the claude/intelligent-brahmagupta-3w188l branch November 15, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants