You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
facet_time_limit_ms and sql_time_limit_ms overlap? #1780
I needed more than the default 200ms to facet a specific column in a database I was working with, so I ran datasette with --setting facet_time_limit_ms 30000 — definitely overkill!
But it still didn't work; it took a moment to realize I also needed to up my sql_time_limit_ms to something larger too.
I'm happy to submit a PR that documents this behavior if it's helpful. Or, if there's a code change we'd like to make (like making sure sql_time_limit_ms is always set to the larger of itself and facet_time_limit_ms), happy to do that too.
Apologies if I missed this somewhere in the docs. And: thanks. I'm really enjoying the simple, effective tooling datasette gives me out of the box for exploring my databases!
Activity
simonw commentedon Aug 15, 2022
This is deliberate, but maybe it's a bad design decision?
Right now Datasette assumes you made a mistake if you set
facet_time_limit_mshigher thansql_time_limit_msand ignores you.Maybe it would be better if it refused to start the server at all and showed you an error message?
Or perhaps running this should set both of the time limits to 30s:
I'm nervous about doing that though as it feels like it may surprise people who only wanted to increase one of the limits.
Option 3: make it so it's possible for facets to have a greater time limit than SQL queries generally.
Maybe that's the best option? It's not surprising to people, and I think it's reasonable to implement.