-
-
Notifications
You must be signed in to change notification settings - Fork 21
Fix members only stream error & update video metadata #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HitomaruKonpaku
wants to merge
51
commits into
sigvt:master
Choose a base branch
from
HitomaruKonpaku:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
bbc8c9e
Disable assertPlayability to avoid error on members only stream
HitomaruKonpaku 2de2a0a
Parse more video metadata from html
HitomaruKonpaku e5c8b6b
Format & update typing
HitomaruKonpaku e2e969c
Fix milestone message `durationText` parser
HitomaruKonpaku f663e17
Skip error actions
HitomaruKonpaku 0849ac9
Add chat metadata isMembersOnly
HitomaruKonpaku e8d4f5e
Try to fix build issue
HitomaruKonpaku c4182c3
Fix for membersOnly stream
HitomaruKonpaku b902acd
Store video extra metadata
HitomaruKonpaku 66eaa30
Allow to update metadata & extend masterchat
HitomaruKonpaku 0132e74
Fix unreachable code
HitomaruKonpaku 820cf71
Update YTLiveChatPollRenderer payload
HitomaruKonpaku 297cb6b
Update function access modifiers
HitomaruKonpaku 29dcb0a
Update metadata parser
HitomaruKonpaku df729d4
Update metadata interface
HitomaruKonpaku ad4e10c
Update metadata parser
HitomaruKonpaku 712a012
Add isUpcoming
HitomaruKonpaku 9727fdf
release: v1.2.0
HitomaruKonpaku 5eb75b9
Ignore cheerio type
HitomaruKonpaku 999b6a2
Update README
HitomaruKonpaku e873c9d
Add membership to addMembershipTickerAction
HitomaruKonpaku 5e03fc6
Update addBannerToLiveChatCommand from stu43005/masterchat
HitomaruKonpaku b15aa48
Update assertPlayability
HitomaruKonpaku 8666af4
Update assertPlayability
HitomaruKonpaku 5477ae1
Throw some data on MembersOnlyError
HitomaruKonpaku 1ef1a39
Fix error
HitomaruKonpaku d02f025
Ability to set timeoutLength in timeoutParams
FlashlightXi 8650ff7
Fix flatMap Type Error
FlashlightXi d2998bd
Delete iterator-helpers-polyfill
FlashlightXi d7bbf83
Merge pull request #1 from FlashlightXi/master
HitomaruKonpaku d796dd5
Add bot error
HitomaruKonpaku 1ab38d7
Refactor
HitomaruKonpaku baa1066
Update docs url
HitomaruKonpaku 036f789
Update CHANGELOG
HitomaruKonpaku ae0d899
release: v1.3.0
HitomaruKonpaku 97a8c22
Fix MembersOnly chat
HitomaruKonpaku 1fc8b05
Update error info
HitomaruKonpaku af71d08
Rollback & Refactor as YT not allow membersOnly without credentials a…
HitomaruKonpaku 1ef4811
Add more detail to addOutgoingRaidBannerAction & addIncomingRaidBanne…
HitomaruKonpaku 6054388
Ignore BotError
HitomaruKonpaku 44fcc04
Add emojis
HitomaruKonpaku 794f4b2
Emit payload for more control
HitomaruKonpaku 44fd4ce
Allow custom cookies
HitomaruKonpaku 49ef0fb
Update doc
HitomaruKonpaku 23d2638
Fix channel parser for `Collaborators` case
HitomaruKonpaku 873d50b
Update by pass YT check
HitomaruKonpaku 89cfd18
Update bypass condition
HitomaruKonpaku 617ca5c
Send more data on error
HitomaruKonpaku 40bcf40
Update error data
HitomaruKonpaku 8bdd7cd
Allow to provide custom clientVersion
HitomaruKonpaku d10f430
Change access
HitomaruKonpaku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you parsed the metadata but I don't think you're exposing it anywhere at all?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we just return simple data (title/channelId/channelName)
But I just think we can return full metadata in case anyone need 🤔