Respect explicit --log-color and auto-detect from stdout - #9907
Open
ackintosh wants to merge 2 commits into
Open
Respect explicit --log-color and auto-detect from stdout#9907ackintosh wants to merge 2 commits into
ackintosh wants to merge 2 commits into
Conversation
`--log-color` was ignored whenever stdin was not a terminal, so users running Lighthouse in Docker could not enable colored logs at all, even with `--log-color true`.
|
Some required checks have failed. Could you please take a look @ackintosh? 🙏 |
mergify
Bot
added
waiting-on-author
mergify
Bot
added
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #8122
--log-colorwas ignored whenever stdin was not a terminal, so users running Lighthouse in Docker could not enable colored logs at all, even with--log-color true.Proposed Changes
This PR makes
--log-colorfirst-class:--log-color[=<bool>], always honor itAdditional Info
The auto-detection now inspects
stdoutrather thanstdin.log_coloronly feeds the stdoutLoggingLayer— file output has its own--logfile-color—, so what matters is whether the sink interprets ANSI escapes, not whether the session is interactive.