Fix payload availability lookup using the parent block's slot (alpha.13) by eserilev · Pull Request #9761 · sigp/lighthouse

eserilev · 2026-08-06T06:46:50Z

Issue Addressed

mergify · 2026-08-06T07:09:27Z

Some required checks have failed. Could you please take a look @eserilev? 🙏

chong-he

Looks great. The main change in the consensus-specs PR is about adding the parent_slot in the functions get_attestation_participation_flag_indices and process_attestations. They are also added here now.

chong-he · 2026-08-10T10:03:47Z

    }

-    fn compute_beacon_block_attestation_reward_altair_deneb<
+    fn compute_beacon_block_attestation_reward_altair_and_later<


Just noting here that this is a nice rename of the function

chong-he · 2026-08-10T10:05:59Z

            let data = attestation.data();
            let inclusion_delay = state.slot().safe_sub(data.slot)?.as_u64();
+
            // [Modified in Deneb:EIP7045]


I am not sure do we always have this kind of comments like the consensus spec? But this comment is stale now that the function get_attestation_participation_flag_indices is modified in Gloas.

Maybe we can delete the comment or update it? Maybe deleting is cleaner.

pawanjay176

Codex flagged some issues here that I don't think I can fully validate.
@dapplion would be really good to have your review on this one

pawanjay176 · 2026-08-13T01:33:00Z

        let mut previous_epoch_participation =
            state.previous_epoch_participation()?.to_owned_list();

+        let parent_slot = state


Codex tells me that for gloas, we need to run process_parent_execution_payload first before this is run because it modifies state.execution_payload_availability which is used below in get_attestation_participation_flag_indices

yeah i think we probably should have made a change here when we deferred payload processing to the next slot (ethereum/consensus-specs#5094) in alpha spec 5?

Anyways good catch, i opened a separate PR with these changes

Nice, thanks!

pawanjay176 · 2026-08-13T01:42:35Z


                let data = unaggregated_attestation.data();

+                let parent_slot = state


Potentially same issue here? we might end up reporting the wrong thing here.

yeah similar thing here, fix is in this PR #9828

mergify · 2026-08-18T02:13:54Z

Merge Queue Status

✅ Entered queue — 2026-08-18 02:13 UTC · Rule: default · triggered by the @mergifyio queue command
❌ Checks timed out — 2026-08-18 02:15 UTC · on draft merge queue: checking unstable (44264fc) and [#9761 + #9763 + #9764] together #9845
✂️ Bisecting to identify the failing PR (round 1/1)
❌ Checks failed · on draft merge queue: checking unstable (44264fc) and #9761 together #9847 · identified as the failing PR
🚫 Left the queue — 2026-08-18 05:37 UTC · at 4aeb5eb4cde14d459e768b626799863c9a54a4c3

This pull request spent 3 hours 24 minutes 3 seconds in the queue, including 3 hours 22 minutes 15 seconds running CI.

Waiting for

check-success=local-testnet-success
check-success=test-suite-success

All conditions

check-success=local-testnet-success
check-success=test-suite-success
depends-on = sigp/lighthouse#9760 [⛓️ Add dependent root check to proposer preferences validation (alpha.13) #9760]
- Fix payload availability lookup using the parent block's slot (alpha.13) #9761
github-review-approved [🛡 GitHub branch protection]
- Fix payload availability lookup using the parent block's slot (alpha.13) #9761

Reason

The merge conditions cannot be satisfied due to failing checks

test-suite-success

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

mergify · 2026-08-18T18:22:04Z

Merge Queue Status

✅ Entered queue — 2026-08-18 18:21 UTC · Rule: default · triggered by the @mergifyio queue command
🟠 Checks running · on draft merge queue: checking unstable (b8cc497) and #9761 together #9855
🚫 Left the queue — 2026-08-18 18:34 UTC · at 86a1c14b9b19fa88890ddf27f3341a82aa428681

This pull request spent 12 minutes 12 seconds in the queue, with no time running CI.

Waiting for

check-success=local-testnet-success
check-success=test-suite-success

All conditions

check-success=local-testnet-success
check-success=test-suite-success
github-review-approved [🛡 GitHub branch protection]
- Fix payload availability lookup using the parent block's slot (alpha.13) #9761

Reason

Pull request #9761 has been dequeued by @pawanjay176 with a dequeue command

Requeued — the merge queue status continues in this comment ↓.

pawanjay176 · 2026-08-18T18:26:26Z

@mergify dequeue

mergify · 2026-08-18T18:49:12Z

eserilev added gloas ready-for-review The code is ready for review labels Aug 6, 2026

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 6, 2026

eserilev force-pushed the gloas-payload-availability-parent-slot branch 2 times, most recently from e37f83c to ed908df Compare August 6, 2026 08:32

eserilev force-pushed the gloas-payload-availability-parent-slot branch from ed908df to 4696330 Compare August 6, 2026 08:35

pawanjay176 mentioned this pull request Aug 6, 2026

Allow multiple bids compatible with the head view (alpha.13) #9763

Merged

pawanjay176 force-pushed the gloas-payload-availability-parent-slot branch from 4696330 to 341f939 Compare August 6, 2026 22:33

eserilev force-pushed the gloas-payload-availability-parent-slot branch from 341f939 to b6976c0 Compare August 7, 2026 05:25

eserilev force-pushed the gloas-payload-availability-parent-slot branch from b6976c0 to be02cff Compare August 10, 2026 08:40

chong-he approved these changes Aug 10, 2026

View reviewed changes

eserilev force-pushed the gloas-payload-availability-parent-slot branch 2 times, most recently from 25c6ffb to e150bbf Compare August 11, 2026 05:43

eserilev force-pushed the gloas-payload-availability-parent-slot branch from e150bbf to b94b981 Compare August 12, 2026 11:26

pawanjay176 requested changes Aug 13, 2026

View reviewed changes

pawanjay176 requested a review from dapplion August 13, 2026 01:55

eserilev force-pushed the gloas-payload-availability-parent-slot branch from b94b981 to f11c285 Compare August 13, 2026 10:56

eserilev force-pushed the gloas-payload-availability-parent-slot branch from f11c285 to 2409d25 Compare August 13, 2026 18:50

mergify Bot added the dequeued label Aug 18, 2026

mergify Bot added the queued label Aug 18, 2026

mergify Bot mentioned this pull request Aug 18, 2026

merge queue: checking unstable (44264fc) and [#9761 + #9763 + #9764] together #9845

Closed

46 tasks

mergify Bot removed the dequeued label Aug 18, 2026

This was referenced Aug 18, 2026

merge queue: checking unstable (44264fc) and #9761 together #9847

Closed

merge queue: checking unstable (44264fc), #9761 and #9763 together #9848

Closed

merge queue: checking unstable (44264fc) and [#9763 + #9764] together #9849

Closed

mergify Bot added dequeued and removed queued labels Aug 18, 2026

eserilev force-pushed the gloas-payload-availability-parent-slot branch from 4aeb5eb to 894bb39 Compare August 18, 2026 10:09

mergify Bot removed the dequeued label Aug 18, 2026

Fix payload availability lookup using the parent block's slot

86a1c14

pawanjay176 force-pushed the gloas-payload-availability-parent-slot branch from c304832 to 86a1c14 Compare August 18, 2026 18:06

mergify Bot added the queued label Aug 18, 2026

mergify Bot mentioned this pull request Aug 18, 2026

merge queue: checking unstable (b8cc497) and #9761 together #9855

Closed

8 tasks

This was referenced Aug 18, 2026

merge queue: checking unstable (b8cc497), #9761 and #9763 together #9856

Closed

merge queue: checking unstable (b8cc497) and [#9763 + #9764] together #9857

Closed

merge queue: checking unstable (b8cc497) and #9764 together #9858

Closed

mergify Bot added dequeued and removed queued labels Aug 18, 2026

pawanjay176 added ready-for-review The code is ready for review and removed ready-for-merge This PR is ready to merge. skip-ci Don't run the `test-suite` dequeued labels Aug 18, 2026

This was referenced Aug 18, 2026

merge queue: checking unstable (b8cc497) and [#9761 + #9763] together #9859

Closed

merge queue: checking unstable (b8cc497) and [#9761 + #9763 + #9764] together #9860

Closed


		let data = unaggregated_attestation.data();

		let parent_slot = state

Uh oh!

Conversation

eserilev commented Aug 6, 2026 • edited by pawanjay176 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Addressed

Uh oh!

mergify Bot commented Aug 6, 2026

Uh oh!

chong-he left a comment

Choose a reason for hiding this comment

Uh oh!

chong-he Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

chong-he Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

pawanjay176 left a comment

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

eserilev Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eserilev Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

pawanjay176 Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pawanjay176 Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

eserilev Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Uh oh!

pawanjay176 commented Aug 18, 2026

Uh oh!

mergify Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eserilev commented Aug 6, 2026 •

edited by pawanjay176

Loading

eserilev Aug 16, 2026 •

edited

Loading

mergify Bot commented Aug 18, 2026 •

edited

Loading

mergify Bot commented Aug 18, 2026 •

edited

Loading

mergify Bot commented Aug 18, 2026 •

edited

Loading