Conversation
| docker buildx imagetools create --tag ${IMAGE_NAME}:${latest_tag} ${IMAGE_NAME}:${arch_tag} | ||
| fi | ||
| echo "${IMAGE_NAME}:${arch_tag}" > tags_to_sign_${arch} | ||
| echo "${IMAGE_NAME}:${arch_tag}" >> tags_to_sign_${arch} |
There was a problem hiding this comment.
Any specific reason for this change or just good form?
There was a problem hiding this comment.
since we now have 2 jobs in parallel, I got spooked that file can be overridden. I think the name of the file might even need to be unique per parallel run
There was a problem hiding this comment.
The file is uploaded as an artifact so you need to add ${BASE_TAG} to the file name and ensure that wherever it is used it is properly finding the expected files. I mean it already handles ${arch} you need to ensure that it also handles the addition of ${BASE_TAG} to the name.
a2982a8 to
0bad871
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7263 +/- ##
==========================================
- Coverage 49.48% 48.93% -0.56%
==========================================
Files 303 318 +15
Lines 19898 20625 +727
==========================================
+ Hits 9847 10092 +245
- Misses 9444 9913 +469
- Partials 607 620 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| script: | ||
| - *docker-reader-role | ||
| - docker login -u $CIRCLECI_QUAY_USERNAME -p $CIRCLECI_QUAY_PASSWORD quay.io | ||
| - - docker login -u splunk -p $DOCKER_HUB_TOKEN |
There was a problem hiding this comment.
| - - docker login -u splunk -p $DOCKER_HUB_TOKEN | |
| - docker login -u splunk -p $DOCKER_HUB_TOKEN |
also, should the username be hidden? or is the org name/repo namespace also username for dockerhub?
There was a problem hiding this comment.
we can hide it, I'll do that
458eedd to
f571593
Compare
3 participants
Add logic to push docker images to both docker hub and quay.