Skip to content

Fix search result keyboard navigation - #7913

Open
Ap4sh wants to merge 1 commit into
signalapp:mainfrom
Ap4sh:fix-search-result-shortcuts
Open

Fix search result keyboard navigation#7913
Ap4sh wants to merge 1 commit into
signalapp:mainfrom
Ap4sh:fix-search-result-shortcuts

Conversation

@Ap4sh

@Ap4sh Ap4sh commented Jun 6, 2026

Copy link
Copy Markdown

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A pnpm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Fixes #5176

Adds next/previous keyboard navigation for loaded search results, including chats, contacts, and message results

This also wires selected state for message search results, so moving to a message result can highlight the matching row. There was an older PR for this in #5234, but it no longer applies cleanly; this keeps the same issue scoped to current main

Tests:

  • pnpm run ready
  • targeted electron-mocha for LeftPaneSearchHelper and LeftPaneArchiveHelper: 50 passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next / previous conversation keyboard shortcuts do not work in search results

1 participant