Fix supertab freezing the app - #6965
Open
Wallunen wants to merge 1 commit into
Open
Conversation
Member
|
When are you experiencing this infinite loop error? |
Author
Whenever the main UI is not on screen, like when the app is starting up, or before logging in. (Also, it's not an "error"; the app just freezes forever until I force-quit it.) The loop runs forever because the |
jamiebuilds-signal
self-requested a review
August 8, 2024 16:06
Wallunen
commented
Sep 13, 2024
| (focusedElement != null && target === focusedElement) || | ||
| target.contains(focusedElement) | ||
| ) { | ||
| if (target.contains(focusedElement)) { |
Author
There was a problem hiding this comment.
target.contains(focusedElement) makes the preceding condition pointless because .contains() allows a null parameter and considers elements to also contain themselves.
| } | ||
|
|
||
| // Super tab :) | ||
| // Super tab :( |
Author
There was a problem hiding this comment.
Signal Spirits haunt this codebase. Let the frown scare them away.
Removes the infinite, app-freezing while-loop and handles the now-reachable errors.
Wallunen
force-pushed
the
fix-supertab
branch
from
September 23, 2024 22:46
5ee127f to
abc6e9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchnpm run readyrun passes successfully (more about tests here)Description
Removes pointless conditions and the infinite, app-freezing while-loop.