Repository navigation
Remove unpatched sprintf-js from development tooling - #39
Merged
Merged
Conversation
📊 Node.js Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unpatched
sprintf-jsdependency reached through Jest's NYC configuration loader. A parent-scoped pnpm override moves only@istanbuljs/load-nyc-configtojs-yaml@4.3.2, retaining the loader'sload()API and replacing the legacy argparse 1 dependency path.The frozen lock removes the obsolete YAML 3, argparse 1, and sprintf-js records. The seven-day release age, APFS import mode, and build-script restrictions are preserved; YAML 4.3.2 was published August 26 and passed pnpm's supply-chain validation.
Validation on Node 24.21.0 / pnpm 12.7.0: fresh frozen install; all 106 tests / 8 suites; build, lint, and docs (one existing Errors warning). Focused checks exercise real NYC YAML configuration with includes/excludes, inheritance and camel-case options, plus YAML CLI input/help/version.
Current October 22 audit changes from six findings to five:
sprintf-jsis gone. The remaining three Handlebars findings are covered by #36. The other two are markdown-it findings; patched 14.3.3 becomes eligible under the unchanged seven-day policy at 2026-10-23 01:47:54.675 UTC (October 22, 9:47 PM EDT). This PR does not claim a clean audit or replace #36. Mermaid-specific findings on the 2.x branches are being handled separately.