Skip to content

fix: ship the baseline action in the package - #42

Merged
Daniel Vien (daniel3010) merged 2 commits into
trunkfrom
fix/ship-baseline-action
Oct 9, 2026
Merged

Daniel Vien (daniel3010) merged 2 commits into
trunkfrom
fix/ship-baseline-action

Conversation

@daniel3010

@daniel3010 Daniel Vien (daniel3010) commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

The baseline action from #38 never shipped: /.github export-ignore (#32) leaves the whole directory out of the archive GitHub builds for a tag. That archive is what a workflow downloads for uses: shopware/dynamodb-dal-bundle/.github/actions/baseline@<tag> and what Composer installs from Packagist, so both fail with "Can't find 'action.yml'". The bundle's own CI uses the action from its checkout, so it didn't notice.

  • .gitattributes export-ignores the entries of .github one by one and re-includes actions/baseline: git skips everything below an export-ignored directory, so the directory itself can't be ignored. New files under .github stay out of the package.
  • The validate job checks that the archive's .github holds exactly actions/baseline/action.yml.
  • The README shows the action from vendor/ first, so that it matches the installed version, and says it ships from 0.7.1.

@daniel3010
Daniel Vien (daniel3010) marked this pull request as ready for review October 9, 2026 05:17
@daniel3010
Daniel Vien (daniel3010) merged commit 9c1df58 into trunk Oct 9, 2026
14 checks passed
@daniel3010
Daniel Vien (daniel3010) deleted the fix/ship-baseline-action branch October 9, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants