Skip to content

Fix:#2328 - #2340

Open
Ankit-cs wants to merge 1 commit into
shipwright-io:mainfrom
Ankit-cs:main
Open

Fix:#2328#2340
Ankit-cs wants to merge 1 commit into
shipwright-io:mainfrom
Ankit-cs:main

Conversation

@Ankit-cs

@Ankit-cs Ankit-cs commented Sep 7, 2026

Copy link
Copy Markdown

Changes

Updates hack/install-spruce.sh to securely download the matching SHA1 checksum asset and verify the Spruce binary's integrity (sha1sum --check) before installing it.

This resolves a potential vulnerability where corrupted or maliciously modified binaries could be silently executed and installed, bringing the script in line with the secure validation pattern already used in install-kubectl.sh.

Related Issue

Fixes: #2343

Type of PR

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • [] Kind label has been set
  • [] Release notes block has been filled in, or marked NONE

Release Notes

Fixed a potential security vulnerability in `hack/install-spruce.sh` by verifying the SHA1 checksum of the downloaded Spruce binary before installation.

@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2026
@openshift-ci openshift-ci Bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2026
@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign irvingmg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaizakin

kaizakin commented Sep 7, 2026

Copy link
Copy Markdown
Member

hey @Ankit-cs

there are certain things that are missing in this PR

  • please sign your commits else we can't accept em you can do it by git commit --amend -s
  • please edit your PR description against the PR template (especially the release note)
  • a better PR title would be better
  • the fixes #Issue number is incorrect

@pull-request-size pull-request-size Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2026
@pull-request-size pull-request-size Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2026
@Ankit-cs

Ankit-cs commented Sep 7, 2026

Copy link
Copy Markdown
Author

ok sir i look for that

Signed-off-by: Ankit-cs <ankitcareer018@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants