Skip to content

Stop storage migration wait loop on failed jobs - #2194

Open
officialasishkumar wants to merge 1 commit into
shipwright-io:mainfrom
officialasishkumar:fix/storage-migration-failure-wait
Open

Stop storage migration wait loop on failed jobs#2194
officialasishkumar wants to merge 1 commit into
shipwright-io:mainfrom
officialasishkumar:fix/storage-migration-failure-wait

Conversation

@officialasishkumar

@officialasishkumar officialasishkumar commented May 11, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Wait for the storage version migration Job to reach either Complete=True or Failed=True.
  • Preserve the existing failure handling so failed migration logs are printed before the script exits.

Related Issue

Fixes #1680

Type of PR

/kind bug

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

Release Notes

The storage version migration script now exits when the migration job reaches a failed terminal state instead of waiting indefinitely.

@openshift-ci openshift-ci Bot added the release-note Label for when a PR has specified a release note label May 11, 2026
@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2026
@openshift-ci openshift-ci Bot added the kind/bug Categorizes issue or PR as related to a bug. label May 11, 2026
@openshift-ci
openshift-ci Bot requested review from SaschaSchwarze0 and rxinui May 11, 2026 19:32
@IrvingMg

Copy link
Copy Markdown
Member

Could you please sign off your commit so the DCO check passes? You can amend it with git commit --amend -s --no-edit and force-push the update.

@SaschaSchwarze0
SaschaSchwarze0 force-pushed the fix/storage-migration-failure-wait branch from 49cb9da to eedeae6 Compare September 2, 2026 19:11
@SaschaSchwarze0

Copy link
Copy Markdown
Member

Rebased ^^

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @officialasishkumar, the code change looks fully correct to me. However, as Irving stated, we require signed commits and cannot take your commit as-is.

/approve

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2026
@SaschaSchwarze0 SaschaSchwarze0 added the dco-missing Pull request with missing commit signature. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-missing Pull request with missing commit signature. kind/bug Categorizes issue or PR as related to a bug. release-note Label for when a PR has specified a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[BUG] storage version migration script runs infinitely

4 participants