Make unit tests independent of external services

[officialasishkumar]

Changes

• Replace Git command execution and TCP checks in command/unit tests with package-local fakes.
• Stub Trivy execution in vulnerability scan unit tests and image-processing command tests.
• Use local test registries and listeners instead of public GitHub, GHCR, and network endpoints.

Related Issue

Fixes #1865

Type of PR

/kind bug

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Kind label has been set
• Release notes block has been filled in, or marked NONE

Release Notes

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[IrvingMg]

Could you please sign off your commit so the DCO check passes? You can amend it with git commit --amend -s --no-edit and force-push the update.

[SaschaSchwarze0]

The correct approach of mocking things would be to define interfaces with an implementation and fake that we would be using in tests. We cannot move Ginkgo into the production code packages to be able to overwrite private functions.

[SaschaSchwarze0]

We cannot do this. The price of hermetic tests cannot be to mix test and production code into a single package. Whether it actually affects binary size with the global Describe call in Ginkgo style and the dot imports I am not entirely sure, but I assume so.

[SaschaSchwarze0]

Same concern here.