feat(agents): emit decision.answered and decision.defaulted telemetry (spec 136)

[arielshad]

What

This is the telemetry follow-up noted in #922 and #924. Every recorded answer to an agent decision now emits decision.answered, and a background agent's question that reaches its deadline emits the new decision.defaulted event. Both go through the ITelemetry port from #923.

Event	Properties	Recorded by
decision.answered	kind (DecisionKind), surface (new DecisionSurface: web / cli / chat / supervisor / other), latency (bucket from asked to answered), pickedRecommended	AnswerAgentQuestionUseCase, once per answer it actually records
decision.defaulted	kind, timeout (bucket of the deadline the agent set)	AskAgentDecisionUseCase, when its deadline settle wins

Why

Spec 133 defined decision.answered but did not emit it, and its kind and surface were raw strings. The T3 Code review asks three things that need data: whether people answer agent questions, where they answer them, and whether they take the recommendation. It also asks how often agents proceed on their own at the deadline.

• Emit points: each event is emitted right after the use case's atomic settlePending succeeds. Each decision is therefore counted exactly once without an onceKey. A lost race (CLI vs web), a refused answer, or agent questions being off records nothing. A person answering at the deadline records an answer, not a default.
• Surface: each caller passes its own surface: the web action (web, which overrides anything the client sends), the CLI (cli), the chat bridge (chat) and the supervisor router (supervisor). Nothing parses the free-form answeredBy actor.
• Typing: in the property map, kind and surface are now enums. That makes the compiler reject a content property at every emit site.
• Refactor while touching the file: the AskAgentDecisionOutcome string union is now the DecisionOutcome enum, with a new Disabled member. The MCP tool's wire values are unchanged. Stored questions use RecordedDecisionOutcome, which excludes Disabled, so the activity log needs no UI for a state it can never show.
• Docs: docs/telemetry.md lists both events. Spec: specs/136-decision-telemetry/. It was renumbered from 135, which belongs to feat(web): review cleanup — per-area feature flags, ASPM off by default #925; the branch name still says 135.

Screenshots / Recording

No UI changes.

Testing

• answer-agent-question.use-case.test.ts:
  • Properties for a decision answered on the web, including the latency bucket with a faked clock and pickedRecommended: true.
  • Typed text counts as not the recommendation.
  • A legacy question is reported as Legacy, with Other as the default surface.
  • Answering twice records one event.
  • Agent questions off, or a refused answer, records nothing.
• ask-agent-decision.use-case.test.ts:
  • The deadline default records decision.defaulted with the timeout bucket.
  • A person answering at the deadline records no default.
  • Cancelled and disabled outcomes record no default.
• Caller tests assert the surface they pass: web action, CLI answer (with --answer and interactive), chat bridge, supervisor router.

Ran locally: pnpm lint, format:check, check:stories, typecheck, test:unit (14864 passed), test:int (2132 passed), build, build:web, build:storybook, and generate with a clean diff. After the renumbering: lint, format:check, typecheck and the affected test files.

Checklist

• pnpm lint passes
• pnpm format:check passes
• pnpm typecheck passes
• pnpm test:unit and pnpm test:int pass
• pnpm build succeeds
• (Domain changes) pnpm tsp:compile ran and packages/core/src/domain/generated/output.ts is committed
• Tests landed RED-first per the TDD guide
• No domain/ or application/ file imports anything from infrastructure/
• Commit messages follow Conventional Commits

🤖 Generated with Claude Code

https://claude.ai/code/session_014Zwb23kb4xTBxJtqc2hKbU