fix(ApfsDir): fallback to linear scan on hash lookup failure for unicode filenames - #218
Open
adithayyil wants to merge 1 commit into
Open
fix(ApfsDir): fallback to linear scan on hash lookup failure for unicode filenames#218adithayyil wants to merge 1 commit into
adithayyil wants to merge 1 commit into
Conversation
Hash mismatch can occur with certain Unicode filenames (ex: emojis) due to normalization differences between macOS and the hash computed by apfs-fuse. Fall back to a byte-by-byte linear scan of directory entries before giving up, allowing access to previously inaccessible directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directories with certain Unicode filenames (e.g. emoji) are visible via
readdirbut inaccessible vialookup. The hashapfs-fusecomputes for the filename doesn't match the hash stored on disk by macOS, causing the B-tree lookup to silently fail withENOENT.The fix adds a linear scan fallback in
LookupName: if the hash-based B-tree lookup fails, fall back to iterating through the parent directory entries viaListDirectoryand compare filenames byte-by-byte. Only triggers on hash misses so normal lookups are unaffected.Tested on an encrypted APFS USB volume (case-sensitive) with an emoji directory name (
🫣) that was previously completely inaccessible on Linux.