Pass USE_FUSE2 define to apfs-fuse build under macOS - #134
Open
msbit wants to merge 1 commit into
Open
Conversation
As the OSXFUSE version of FUSE is v2, add the same call to `target_compile_definitions` in the check for `APPLE` as for the check against `USE_FUSE2` when `APPLE` isn't defined
OothecaPickle
approved these changes
Nov 27, 2020
|
Just hit this issue, and PR fixes it. Please merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my mac, with the lastest OSXFUSE version (3.11.2), the version of FUSE that is installed is actually 2.9.7:
so compiling
apfs-fusewithout definingUSE_FUSE2breaks with the following output (which is the same as for #118):The fix here is to specify the same
target_compile_definitionsfor builds withAPPLEdefined as for those withoutUSE_FUSE3=ONwould otherwise.