Skip to content

feat: prefill nickname dialog with contact name - #2019

Open
lidarbtc wants to merge 1 commit into
session-foundation:devfrom
lidarbtc:lidarbtc/prefill-contact-nickname
Open

lidarbtc wants to merge 1 commit into
session-foundation:devfrom
lidarbtc:lidarbtc/prefill-contact-nickname

Conversation

@lidarbtc

@lidarbtc lidarbtc commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Prefill the nickname field with the contact's profile name when no nickname is set, so it can be edited without retyping it. Existing nicknames still take priority, and contacts without either name keep an empty field.

Closes #309.

Screenshots

Before After
Empty nickname field Contact name prefilled

Testing

pnpm ready passed on Ubuntu 26.04.1 with Node 24.12.0 and pnpm 10.28.1, including the dependency deduplication check, full build, lint, and all 963 existing tests.

Checked the dialog in Electron 40 under Xvfb using a temporary account and two synthetic contacts. The profile name appeared on first opening, saved nicknames took priority, and cancelling edits left the stored name unchanged. Saving updated the conversation name; removing the nickname restored the profile name. Clearing the field or opening a contact without either name left Save disabled.

No new tests were added.

First time contributor checklist

  • I have read the README and Contributor Guidelines.

Contributor checklist

  • My commits are in logical chunks with descriptive commit messages.
  • My changes are based on the latest dev branch (a41ae8275).
  • pnpm ready passes successfully.
  • My changes are ready to be shipped to users.

@lidarbtc
lidarbtc marked this pull request as ready for review October 3, 2026 05:53
@lidarbtc

lidarbtc commented Oct 5, 2026

Copy link
Copy Markdown
Contributor Author

@Bilb Since this is a feature PR, feel free to close it if you don't think it fits here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] user rename (change nickname) function can pre-fill current username into the input box?

1 participant