Repository navigation
Conversation
lidarbtc
marked this pull request as ready for review
October 3, 2026 05:53
Contributor
Author
|
@Bilb Since this is a feature PR, feel free to close it if you don't think it fits here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefill the nickname field with the contact's profile name when no nickname is set, so it can be edited without retyping it. Existing nicknames still take priority, and contacts without either name keep an empty field.
Closes #309.
Screenshots
Testing
pnpm readypassed on Ubuntu 26.04.1 with Node 24.12.0 and pnpm 10.28.1, including the dependency deduplication check, full build, lint, and all 963 existing tests.Checked the dialog in Electron 40 under Xvfb using a temporary account and two synthetic contacts. The profile name appeared on first opening, saved nicknames took priority, and cancelling edits left the stored name unchanged. Saving updated the conversation name; removing the nickname restored the profile name. Clearing the field or opening a contact without either name left Save disabled.
No new tests were added.
First time contributor checklist
Contributor checklist
devbranch (a41ae8275).pnpm readypasses successfully.