Release 1 9 0 - #418
Draft
gwright99 wants to merge 8 commits into
Draft
Release 1 9 0#418gwright99 wants to merge 8 commits into
gwright99 wants to merge 8 commits into
Conversation
- Original solution attached security groups to the Launch Template that defined EC2 details. - It was discovered that n+1 changes which required added/removing a security group on the EC2 would not occured. This was ultimately due to the "frozen" nature of the LT. - Fix was to defined reconciled security groups directly onto the EC2. - To maintain compatility with other solution mechanisms, SGs also defined on LT, but we now ignore LT changes and attach the new SG group directly to EC2.
* fix: updated Studios SSH EC2 security groups - EC2 was allowing traffic from anywhere for Studios SSH. It should only allow traffic from NLB (which should itself have a security group). - Tightened security group on EC2 and implemented security group on NLB via new variable. - Discovered that non-NLB SSH Studios flow was added during original contribution. Will be ripping that out in next commit. * chore: removed SSH Studio without NLB flow.
- Playing with idea to make it easier to do configuration updates during upgrades. - Have not figured out what to do with latest release's changes since tag won't exist until I'm ready to release and thus the links likely wont be right.
* feat: added 'make check_upgrade' script to help with tfvars migration during upgrade.
* fix: truncated NLB name so total size is >= 32
* refactor: remonolithed separate ansible calls to minimize null_resource count. * refactor: added extra check on batch null_resources -- dont run if seqerakit inactive. * refactor: collapsed additional null_resources to minimize TF resource change noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening for visibility.
Related Issues
Type of Change
Changes
Test Plan
make verifypassesmake planreviewed./tests/run_tests_all.shpassesruffrun on modified Python filesConfiguration / Migration Notes
Screenshots / Output
Checklist
templates/TEMPLATE_terraform.tfvarsif variables changed