feat: always return exit code 0 - #240
Open
Haegi wants to merge 1 commit into
Open
Conversation
|
Thanks @Haegi — this is a thoughtful change. Returning exit code 0 from the cri-client after a successful pull makes the job lifecycle cleaner and avoids confusing operators who see non-zero exits in their logs even when nothing is wrong. I've opened issue #242 to take over as maintainer. This PR would be on my review list early on. Do you have a test case to go along with it, or is the behavior observable from job status alone? |
Owner
|
@Haegi Your proposal requires a shell in the container image. images without a shell would fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now the kube-fledged image cache jobs fail when pulled image fails to execute
/tmp/bin/echo Image pulled successfully!. This is basically true for all container images without a shell like the distroless images.Therefore, it is either not possible to use it with such images or to get a lot of failed jobs in the cluster.
This PR changes the behaviour to always return true and therefore exit code 0, which allows the usage of all images.