Skip to content

fix(java): catch permissive file permission APIs #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xTaoZ wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(java): catch permissive file permission APIs #4034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions java/lang/security/audit/overly-permissive-file-permission.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
package testcode.file.permissions;

import java.io.IOException;
import java.io.File;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.nio.file.attribute.PosixFileAttributeView;
import java.nio.file.attribute.PosixFilePermission;
import java.nio.file.attribute.PosixFilePermissions;
import java.util.HashSet;
Expand Down Expand Up @@ -37,8 +39,42 @@ public static void notOk2() throws IOException {
Files.setPosixFilePermissions(Paths.get("/var/opt/app/init_script.sh"),perms);
}

public static void notOk3() throws IOException {
File file = new File("/var/opt/configuration.xml");
// ruleid:overly-permissive-file-permission
file.setReadable(true, false);
// ruleid:overly-permissive-file-permission
file.setWritable(true, false);
// ruleid:overly-permissive-file-permission
file.setExecutable(true, false);
}

public static void notOk4() throws IOException {
PosixFileAttributeView attrs = Files.getFileAttributeView(
Paths.get("/var/opt/configuration.xml"), PosixFileAttributeView.class);
// ruleid:overly-permissive-file-permission
attrs.setPermissions(PosixFilePermissions.fromString("rw-rw-rw-"));
// ruleid:overly-permissive-file-permission
Files.createTempDirectory(
"temp-",
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-rw-rw-")));
// ruleid:overly-permissive-file-permission
Files.createTempFile(
Paths.get("/tmp"),
"prefix",
"suffix",
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-r--r--")));
// ruleid:overly-permissive-file-permission
Files.createFile(
Paths.get("/var/opt/configuration.xml"),
PosixFilePermissions.asFileAttribute(PosixFilePermissions.fromString("rw-rw-rw-")));
}

public static void ok() throws IOException {
Files.setPosixFilePermissions(Paths.get("/var/opt/configuration.xml"), PosixFilePermissions.fromString("rw-rw----"));
Files.setPosixFilePermissions(Paths.get("/var/opt/configuration.xml"), PosixFilePermissions.fromString("rwxrwx---"));
new File("/var/opt/configuration.xml").setReadable(true, true);
new File("/var/opt/configuration.xml").setWritable(false, false);
new File("/var/opt/configuration.xml").setExecutable(true, true);
}
}
7 changes: 7 additions & 0 deletions java/lang/security/audit/overly-permissive-file-permission.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ rules:
impact: MEDIUM
confidence: LOW
pattern-either:
- pattern: $FILE.setReadable(true, false);
- pattern: $FILE.setWritable(true, false);
- pattern: $FILE.setExecutable(true, false);
- pattern: java.nio.file.Files.setPosixFilePermissions($FILE, java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/"));
- pattern: $ATTRS.setPermissions(java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/"));
- pattern: java.nio.file.Files.createFile($FILE, java.nio.file.attribute.PosixFilePermissions.asFileAttribute(java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/")));
- pattern: java.nio.file.Files.createTempDirectory(..., java.nio.file.attribute.PosixFilePermissions.asFileAttribute(java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/")));
- pattern: java.nio.file.Files.createTempFile(..., java.nio.file.attribute.PosixFilePermissions.asFileAttribute(java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/")));
- pattern: |
$TYPE $P = java.nio.file.attribute.PosixFilePermissions.fromString("=~/(^......r..$)|(^.......w.$)|(^........x$)/");
...
Expand Down