Skip to content

fix(django): let django-no-csrf-token span realistic form bodies #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eljees wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(django): let django-no-csrf-token span realistic form bodies #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba03457
fix(django): let django-no-csrf-token span realistic form bodies
Eljees Jul 28, 2026
c704428
test(django): keep CSRF tokens scoped to their form
Eljees Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions python/django/security/django-no-csrf-token.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,34 @@
</div>
</div>

<!-- a token in a following sibling form must not suppress this finding -->
<div class="container">
<!-- ruleid: django-no-csrf-token -->
<form method="post">
<input type="text" name="unprotected">
<button type="submit">Submit</button>
</form>
<form method="post">
{% csrf_token %}
<input type="text" name="protected">
<button type="submit">Submit</button>
</form>
</div>

<!-- a token in a preceding sibling form must not suppress this finding -->
<div class="container">
<form method="post">
{% csrf_token %}
<input type="text" name="protected">
<button type="submit">Submit</button>
</form>
<!-- ruleid: django-no-csrf-token -->
<form method="post">
<input type="text" name="unprotected">
<button type="submit">Submit</button>
</form>
</div>

<div class="container">
<div class="row">
<div class="col-6">
Expand Down Expand Up @@ -97,3 +125,49 @@
</div>
</div>
</div>

<!-- a nested {% if %} around a multi-line element must not hide the csrf_token -->
<div class="container">
<form method="post">
{% csrf_token %}
<div>
{% if x %}
<div>
{{ y }}
</div>
{% endif %}
</div>
<div>
<!-- ok: django-no-csrf-token -->
<button type="submit">Go</button>
</div>
</form>
</div>

<!-- a longer form without a csrf_token is still reported -->
<div class="container">
<!-- ruleid: django-no-csrf-token -->
<form method="post">
<div class="row-0"><input type="text" name="field_0"></div>
<div class="row-1"><input type="text" name="field_1"></div>
<div class="row-2"><input type="text" name="field_2"></div>
<div class="row-3"><input type="text" name="field_3"></div>
<div class="row-4"><input type="text" name="field_4"></div>
<div class="row-5"><input type="text" name="field_5"></div>
<div class="row-6"><input type="text" name="field_6"></div>
<div class="row-7"><input type="text" name="field_7"></div>
<div class="row-8"><input type="text" name="field_8"></div>
<div class="row-9"><input type="text" name="field_9"></div>
<div class="row-10"><input type="text" name="field_10"></div>
<div class="row-11"><input type="text" name="field_11"></div>
<div class="row-12"><input type="text" name="field_12"></div>
<div class="row-13"><input type="text" name="field_13"></div>
<div class="row-14"><input type="text" name="field_14"></div>
<div class="row-15"><input type="text" name="field_15"></div>
<div class="row-16"><input type="text" name="field_16"></div>
<div class="row-17"><input type="text" name="field_17"></div>
<div class="row-18"><input type="text" name="field_18"></div>
<div class="row-19"><input type="text" name="field_19"></div>
<button type="submit">Go</button>
</form>
</div>
5 changes: 5 additions & 0 deletions python/django/security/django-no-csrf-token.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ rules:
regex: (?i)(post|put|delete|patch)
- pattern-not-inside: "<form...>...{% csrf_token %}...</form>"
- pattern-not-inside: "<form...>...{{ $VAR.csrf_token }}...</form>"
options:
# the default limit of 10 newlines per ellipsis is smaller than a realistic
# form body, which both hides the csrf_token exemption and stops the rule
# from matching longer forms at all
generic_ellipsis_max_span: 50
Comment thread
Eljees marked this conversation as resolved.
message: Manually-created forms in django templates should specify a csrf_token to prevent CSRF attacks.
languages: [generic]
severity: WARNING
Expand Down