Skip to content

Fix uninitialized member variables. - #2226

Open
Dimi1010 wants to merge 8 commits into
seladb:devfrom
Dimi1010:ci/update-cppcheck-member-init-fixes
Open

Fix uninitialized member variables.#2226
Dimi1010 wants to merge 8 commits into
seladb:devfrom
Dimi1010:ci/update-cppcheck-member-init-fixes

Conversation

@Dimi1010

Copy link
Copy Markdown
Collaborator

This PR contains cherrypicked commits from #2199 focusing on fixing uninitialized member variable warnings. Most member variables are initialized to 0 where possible.

Some other changes include:

  • GreLayer: C-cast -> Cpp cast
  • MxDnsResourceData: Constructor parameter uint16 const& changed to uint16_t.
    Passing values of size <= 8 bytes by reference is detrimental, unless needed.
  • TLVData: Added cppcheck suppressions.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.67%. Comparing base (200853b) to head (c05ab72).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2226      +/-   ##
==========================================
+ Coverage   81.30%   82.67%   +1.37%     
==========================================
  Files         319      333      +14     
  Lines       52180    60285    +8105     
  Branches    12124    12864     +740     
==========================================
+ Hits        42423    49842    +7419     
- Misses       7519     9030    +1511     
+ Partials     2238     1413     -825     
Flag Coverage Δ
23.11.6 7.26% <0.00%> (?)
24.11.5 7.30% <0.00%> (?)
25.11.1 7.25% <0.00%> (?)
alpine320 76.86% <100.00%> (+<0.01%) ⬆️
fedora42 76.44% <100.00%> (+<0.01%) ⬆️
macos-15 82.27% <100.00%> (+0.01%) ⬆️
macos-26 82.28% <100.00%> (+0.01%) ⬆️
macos-26-intel 82.20% <100.00%> (+<0.01%) ⬆️
mingw32 71.47% <100.00%> (+<0.01%) ⬆️
mingw64 71.45% <100.00%> (+0.08%) ⬆️
rhel94 76.24% <100.00%> (+0.01%) ⬆️
ubuntu2204 76.26% <100.00%> (-0.01%) ⬇️
ubuntu2404 76.58% <100.00%> (+0.02%) ⬆️
ubuntu2604 76.52% <100.00%> (+<0.01%) ⬆️
ubuntu2604-arm64 76.36% <100.00%> (+0.02%) ⬆️
ubuntu2604-icpx 59.07% <100.00%> (+0.02%) ⬆️
unittest 82.67% <100.00%> (+1.37%) ⬆️
windows-2022 85.80% <100.00%> (?)
windows-2025 85.54% <100.00%> (?)
winpcap 85.83% <100.00%> (?)
xdp 52.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants