IGMPv3 tests: Move truncated example from inlined array to a hex resource file. - #2225
Open
Dimi1010 wants to merge 2 commits into
Open
IGMPv3 tests: Move truncated example from inlined array to a hex resource file.#2225Dimi1010 wants to merge 2 commits into
Dimi1010 wants to merge 2 commits into
Conversation
Includes modifications to the ResourceProvider as it was used to generate the data file from the inlined array. - Adds freeze and unfreeze actions to ResourceProvider to allow modifying the frozen setting. - Changes `ResourceProvider::saveResource` to be non-const action.
Dimi1010
commented
Aug 19, 2026
| /// @throw std::runtime_error if the provider is frozen and does not allow saving. | ||
| void saveResource(ResourceType resourceType, const char* filename, const uint8_t* data, | ||
| size_t length) const; | ||
| void saveResource(ResourceType resourceType, const char* filename, const uint8_t* data, size_t length); |
Collaborator
Author
There was a problem hiding this comment.
Stripped the const since it conceptually mutates the resource store.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2225 +/- ##
==========================================
+ Coverage 81.30% 82.66% +1.35%
==========================================
Files 319 332 +13
Lines 52180 60258 +8078
Branches 12124 12860 +736
==========================================
+ Hits 42423 49810 +7387
- Misses 7519 9033 +1514
+ Partials 2238 1415 -823
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Dimi1010
marked this pull request as ready for review
August 19, 2026 18:02
egecetin
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the truncated array to a data file to conform with other tests and allow usage of the
pcpp_tests::createPacketFromHexResourcemachinery.Includes modifications to the
ResourceProvideras it was used to generate the data file from the inlined array.ResourceProviderto allow modifying the frozen setting.ResourceProvider::saveResourceto be non-const action.