-
Notifications
You must be signed in to change notification settings - Fork 753
Add DeviceConfiguration::disableImmediateMode to allow TPACKET_V3 on Linux
#2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MerinoSheep
wants to merge
13
commits into
seladb:dev
Choose a base branch
from
MerinoSheep:feature/disable-immediate-mode
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−5
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
901d191
Add DeviceConfiguration::disableImmediateMode to allow TPACKET_V3 on …
MerinoSheep 896abdb
Tighten disableImmediateMode comments to focus on rationale
MerinoSheep 0e1e60b
Further tighten disableImmediateMode doc comment
MerinoSheep 0d205e3
Fall back to a positive timeout when immediate mode is disabled
MerinoSheep 7f2d640
Don't override FreeBSD/macOS breakloop timeout workaround
MerinoSheep ed70d8e
Tighten disableImmediateMode comments
MerinoSheep 000519b
Simplify timeout selection to a single ternary
MerinoSheep d09e518
Remove redundant Linux mention in disableImmediateMode docs
MerinoSheep a64d279
Merge branch 'dev' into feature/disable-immediate-mode
MerinoSheep df648ec
Replace disableImmediateMode bool with BufferingMode enum
MerinoSheep 3086cd1
Fix pre-commit issues in BufferingMode change
MerinoSheep 0be735f
Move cppcheck suppression to the actually-flagged line
MerinoSheep 848f132
Merge branch 'dev' into feature/disable-immediate-mode
seladb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, positive flags are easier to reason about than negative flags since the reader does not have to negate the condition.
useImmediateModedefaulted totruemight be easier to reason about when looking through the docs.Also, I am wondering, do you think it would be better to have the flag be an enum instead of a bool?
Something like:
Default mode can also possibly have a graceful fallback to buffered, if immediate mode fails to enable for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good idea, Ill change