-
Notifications
You must be signed in to change notification settings - Fork 311
STRATCONN-6892 - [Reddit Conversions API] - add v3 support #3958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joe-ayoub-segment
wants to merge
23
commits into
main
Choose a base branch
from
STRATCONN-6892-reddit-conversions-api-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
266327b
feat(reddit-conversions-api): add v3 support behind feature flag
joe-ayoub-segment c92eaa3
refactor(reddit-conversions-api): drop the v2 file split, restore uti…
joe-ayoub-segment 7baa5e4
Move types-v3/utils-v3 into v3 folder, restore test_mode setting
joe-ayoub-segment 489bc41
Centralize v2/v3 version identifiers into versioning-info.ts
joe-ayoub-segment 34257f7
Extract standardEvent action definition into a reusable factory
joe-ayoub-segment 55fa136
Reframe V2 as standard/V3 as beta; restore V2-pinned presets
joe-ayoub-segment b89918e
Migrate customEvent onto action.ts; drop Flagon flag gating
joe-ayoub-segment cc9f34b
Add per-item batch validation via MultiStatusResponse for V3; lock do…
joe-ayoub-segment 61c98d7
Restructure createRedditPayloadV3 to mirror the legacy whole-batch flow
joe-ayoub-segment dde0afc
Dedupe EVENT_TYPE_V3 into TRACKING_TYPE_V3
joe-ayoub-segment c329461
Dedupe ACTION_SOURCE_V3 into ACTION_SOURCE_V3_LABELS
joe-ayoub-segment b2a796a
Revert test files to main
joe-ayoub-segment b3d8999
updating snapshots
joe-ayoub-segment 3e68c88
Add unit tests for Reddit CAPI v3 single-event action and utils-v3 he…
joe-ayoub-segment d2a97d8
Add batch unit tests for Reddit CAPI v3
joe-ayoub-segment 3e6f685
updating metadata
joe-ayoub-segment 1c1221b
Merge branch 'main' into STRATCONN-6892-reddit-conversions-api-v3
joe-ayoub-segment 989e578
test fixes
joe-ayoub-segment 841ee98
fixing event_metadata bug
joe-ayoub-segment e563895
Merge branch 'main' into STRATCONN-6892-reddit-conversions-api-v3
joe-ayoub-segment 41b3344
fixing pre-existing mapping bug
joe-ayoub-segment 1dfd6b1
STRATCONN-6892: filter event_metadata by tracking_type per Reddit CAP…
joe-ayoub-segment 474e893
Merge branch 'main' into STRATCONN-6892-reddit-conversions-api-v3
joe-ayoub-segment File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
532 changes: 528 additions & 4 deletions
532
...ons/src/destinations/reddit-conversions-api/__tests__/__snapshots__/snapshot.test.ts.snap
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.